Fixes #38219 - fix Ansible Tower API path based on AAP version #10445
+194
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/views/unattended/provisioning_templates/snippet/ansible_tower_callback_service.erb
Outdated
Show resolved
Hide resolved
nofaralfasi
force-pushed
the
fix_aap_version_api
branch
2 times, most recently
from
3487aaa to
6a9a8b5
Compare
nofaralfasi
commented
Feb 20, 2025
app/views/unattended/provisioning_templates/snippet/ansible_tower_callback_script.erb
Outdated
Show resolved
Hide resolved
evgeni
reviewed
Feb 20, 2025
app/views/unattended/provisioning_templates/snippet/ansible_tower_callback_script.erb
Outdated
Show resolved
Hide resolved
| @@ -10,9 +10,17 @@ description: | | |||
| #!/bin/sh | |||
|
|
|||
| echo "Calling Ansible AWX/Tower provisioning callback..." | |||
|
|
|||
| # Query the AC version | |||
| if [ $(echo "$(curl -k -s https://<%= host_param('ansible_tower_fqdn') %>/api/v2/ping/ | jq -r .version | cut -d. -f1,2) >= 4.6" | bc) -eq 1 ]; then | |||
There was a problem hiding this comment.
Just curious to know if /api/v2/ping/ is same endpoint for both versions?
There was a problem hiding this comment.
I have a 4.5.8 where I see the ping endpoint works.. Not sure about even older instances though.
nofaralfasi
force-pushed
the
fix_aap_version_api
branch
from
6a9a8b5 to
74be1c7
Compare
nofaralfasi
changed the title
nofaralfasi
force-pushed
the
fix_aap_version_api
branch
2 times, most recently
from
8b33b97 to
97b1383
Compare
nofaralfasi
requested review from
sayan3296,
evgeni,
Gauravtalreja1 and
ekohl
|
The failing tests seem related. I'm actively working on fixing them, but I'd appreciate a review of the overall implementation. |
nofaralfasi
force-pushed
the
fix_aap_version_api
branch
from
97b1383 to
5437e08
Compare
|
Tests are fixed. The remaining failures are unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.