Extended XMTZC05HM decoder #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pulled back _XMTZC05HM_json_props into XMTZC05HM_json.h - Renamed "model" to more informative "Mi_Body_Scale_2" and amended description in the docs - Implemented 'stabilised' only decoding for XMTZC05HM - Recognises 'stabilised' 2 (scale display active) and 'stabilised' a (scale display deactivated) to guarantee published 'stabilised' reading without the need for very short TimeBtwRead - New 'mode' attribute to indicate if the weighing was of a person or a small object (if this option is activated in the scale's settings). This allows filtering to only record person readings in HA or openHAB - Only publish 'impedance' attribute if the weighing of a person was done barefoot and the impedance value could be recorded correctly I suspect that the 1st version of the Mi Body Composition Scale (XMTZCO2HM) is also being recognised by this decoder, and should therefor be mentioned in the docs and published model_id, but without confirmation of XMTZCO2HM owners this is just a guess.
…into XMTZC05HM-Extended
h2zero
reviewed
Feb 20, 2022
|
I shouldn't hurry with things like that ;) thanks |
Small final changes • abbreviated property names for discovery inclusion • decoder back to original _XMTZC05HM_json Correction of tests Removed rogue old XMTZC05HM test result Property name corrections Fixed test mess up Wrongly deleted test reinstated Decoder clean up Decoder clean up
DigiH
force-pushed
the
XMTZC05HM-Extended
branch
from
e36642e to
788ea63
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that the 1st version of the Mi Body Composition Scale (XMTZCO2HM) is also being recognised by this decoder, and should therefor be mentioned in the docs and published model_id, but without confirmation from XMTZCO2HM owners this is just an assumption.
Checklist: