Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Events are incorrect #73

Closed
RyanZim opened this issue Sep 20, 2016 · 3 comments
Closed

Carousel Events are incorrect #73

RyanZim opened this issue Sep 20, 2016 · 3 comments
Assignees
Labels
bug critical issue

Comments

@RyanZim
Copy link
Contributor

RyanZim commented Sep 20, 2016

The carousel emits two events: slide and slid.

The official bootstrap docs state that the slide event should fire first: http://getbootstrap.com/javascript/#carousel-events. (This makes sense, since slid is the past tense of slide.)

In bootstrap.native, the slid event fires first. This is incorrect.

Here are JSBins demonstrating the problem:

Notice the order that the events fire. This is a bug.

@thednp Urgent ❗

@RyanZim
Copy link
Contributor Author

RyanZim commented Sep 20, 2016

I'm working on a PR.

@thednp
Copy link
Owner

thednp commented Sep 20, 2016

OK, looking at it seems you are right.

@RyanZim
Copy link
Contributor Author

RyanZim commented Sep 20, 2016

@thednp Done, #74.

@thednp thednp added the bug critical issue label Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical issue
Projects
None yet
Development

No branches or pull requests

2 participants