-
-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] issues and improvements for modal #29
Comments
would you also be able to add similar support to bootstraps data-keyboard and data-backdrop http://getbootstrap.com/javascript/#modals-options ? Currently you can keep the modal visible if the user clicks outside of it but the backdrop disappears. Also it'd be nice to prevent the escape key from closing the modal but only for specific dialogs |
We already support those options. I also don't understand perfect what you mean.. are you using multiple opened modals at the same time? |
They don't really work, or I am doing something wrong. Here is a super simple testcase Click the "Launch Simple Modal" button and then click escape. The modal stays but the backdrop disappears. I can reproduce this in both Chrome 46 and FireFox 38. You can also mouse click outside of the modal and it will disappear |
Sorry HTML got stripped out is what you change it to |
If you change the |
Not sure I follow, I'm not changing the values after initializing, I'm just adding them to the example modal on the demo page. The keyboard one is partially taking effect because the modal stays but the backdrop disappears when pressing escape |
So you downloaded the demo, edited the |
Correct I downloaded a zip from github, extracted the files to a new directory, made the one change to index.html on line 228 to add data-backdrop="static" and data-keyboard="false", saved, then opened index.html and clicked on launch simple modal. When I click outside of the modal it disappears which is not what data-backdrop="static" does for bootstrap. When I click escape on my keyboard the modal background disappears but the modal is left in place I'm on windows 7 and can reproduce in Chrome 46 and FireFox 38 Are you not able to reproduce this problem? |
I don't have much time to test (I know if I start testing I usually start working on it and thus takes even more time), so I noted here a little to do for the next release. I also noted your report, so thank you, I will solve the issue asap. |
@osdlge I think your issue is a content related issue, I cannot reproduce the issue at all. |
So when you enable data-backdrop="static" and press the esc key on the modal the backdrop and modal stay in place? The only change I made was to the provided sample and adding data-backdrop="static" data-keyboard="false" tabindex="-1" |
Modal currently doesn't know what |
Done the rework 7985fae |
Issues:
open-modal
classes to the bodymodal-open
, just like the new version of the original pluginThe text was updated successfully, but these errors were encountered: