New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dist/ is not up to date. #24

Closed

HelloGravity opened this issue Oct 5, 2015 · 5 comments

Labels

invalid

Contributor

HelloGravity commented Oct 5, 2015

When building the library with gulp, I noticed there is a difference between the code in lib/ and in dist/ in the repository, and it is in the behavior of collapse:
in lib/ - https://github.com/thednp/bootstrap.native/blob/ddd5d7b/lib/collapse-native.js#L120-L124
in dist/ -https://github.com/thednp/bootstrap.native/blob/ddd5d7b/dist/bootstrap-native.js#L783-L785

Owner

thednp commented Oct 5, 2015

Thanks, will check that too.

Owner

thednp commented Oct 5, 2015

This change is due to the plans to remove resize handlers for IE8. I will update that ASAP.

Owner

thednp commented Oct 9, 2015

I'm now gonna check this too, and closing this down.

thednp closed this as completed

Owner

thednp commented Oct 9, 2015

Please tell me, is this the only difference you found?

Contributor Author

HelloGravity commented Oct 9, 2015

Yes, this was the only code difference. There were also differences in comments.
But now it will also differ because of #23

thednp added the invalid label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment