From 0ad6c1a72cbea28043e86d9ca0ad4114e2d4b138 Mon Sep 17 00:00:00 2001 From: thednp Date: Wed, 26 Oct 2016 16:16:31 +0300 Subject: [PATCH] Further code cleanup and added CONTRIBUTING.md as suggested by @RyanZim https://github.com/thednp/bootstrap.native/pull/80#issuecomment-256335650 --- CONTRIBUTING.md | 12 ++ dist/bootstrap-native.js | 240 ++++++++++++++++++--------------------- lib/affix-native.js | 24 ++-- lib/alert-native.js | 14 +-- lib/button-native.js | 26 ++--- lib/carousel-native.js | 24 ++-- lib/collapse-native.js | 18 ++- lib/dropdown-native.js | 14 +-- lib/modal-native.js | 20 ++-- lib/popover-native.js | 28 +++-- lib/scrollspy-native.js | 30 +++-- lib/tab-native.js | 18 ++- lib/tooltip-native.js | 24 ++-- 13 files changed, 230 insertions(+), 262 deletions(-) create mode 100644 CONTRIBUTING.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md new file mode 100644 index 00000000..0eb542d1 --- /dev/null +++ b/CONTRIBUTING.md @@ -0,0 +1,12 @@ +# Issue Reporting +Before posting a new issue/question, please check the [CLOSED](https://github.com/thednp/bootstrap.native/issues?q=is%3Aissue+is%3Aclosed) issues section, maybe your issue have already been solved or your question was already answered. + +Please use the [Issues](https://github.com/thednp/bootstrap.native/issues) section to post new issues related to Native Javascript for Bootstrap functionality, npm and / or node.js compatibility. + +**Requirements** +* **version** you are using, +* **line number** of the script where the issue happens and any **console error** you may have, +* **step by step guide on reproducing the issue** and a **test site** are great for us to investigate and fix it. + +# Allowed Pull Requests +The custom scripts/developments may not be suitable for everybody so they may get rejected. Generally the PR must explain the issue in detail, link it from issues section and must be **consistent**. \ No newline at end of file diff --git a/dist/bootstrap-native.js b/dist/bootstrap-native.js index 6c797d7a..a4873dd4 100644 --- a/dist/bootstrap-native.js +++ b/dist/bootstrap-native.js @@ -172,21 +172,19 @@ this.resizeEvent() }; - // (function () { - // AFFIX DATA API - // ================= - var Affixes = document.querySelectorAll('[data-spy="affix"]'); - for (var a=0, afl = Affixes.length; a