Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #70

Closed
abhijithvijayan opened this issue Nov 7, 2019 · 7 comments
Closed

Release #70

abhijithvijayan opened this issue Nov 7, 2019 · 7 comments

Comments

@abhijithvijayan
Copy link
Member

3.1.1 is released.

@poeti8

Store is behind 4 versions

@poeti8
Copy link
Member

poeti8 commented Dec 3, 2019

Oops, ok will do soon.

@poeti8
Copy link
Member

poeti8 commented Dec 4, 2019

@abhijithvijayan Get this warning from Chrome store:

image

@abhijithvijayan
Copy link
Member Author

So, sorry about that.

I am not sure what happened there.

Please delay the upgrade until I figure out what caused this error.

@abhijithvijayan
Copy link
Member Author

Its a new warning as well as a suggestion raised ny chrome store.

I didn't change any permission since the last release

They are suggesting to use activeTab permission instead of Tabs permission.

I will accept the recommendation and switch to using it and test the new permission and will release it soon.

Will notify you once completed.

@poeti8
Copy link
Member

poeti8 commented Dec 4, 2019

Yes got the warning for previous versions too but didn't see activeTab suggestion, I thought it would be useful.

@abhijithvijayan
Copy link
Member Author

abhijithvijayan commented Dec 12, 2019

@poeti8 I have changed tabs permission to activeTab and also refactored some code.

Even still, google might warn about broad host permissions as using https://*/* and http://*/* which is required for the extension to request data to custom host api endpoint.

Ignore the warning if it shows up.

Please do update both the stores with version 3.2.1

Also, please take a look at issue #71 and post if you are okay with the changes proposed as well.

Thanks

@poeti8
Copy link
Member

poeti8 commented Dec 14, 2019

Submitted, thanks. And yes, still got the warning, it's not important at this point, the review just might take longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants