You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! This is more of a request rather than a feature/bug.
Recently I included this package in PHP-Scoper and I encountered a few issues... Indeed, PHP-Scoper changes the namespace, and for not breaking globally registered user functions, it aliases the ones it came across with a statement like so:
if (!function_exists('preprocessGrammar')) { functionpreprocessGrammar() { return\_HumbugBox57f37d5ac4d1\preprocessGrammar(...func_get_args()); } }
And turns out there was quite a few symbols for this project! The real issue however, is because PHP-Scoper relies on https://github.com/JetBrains/phpstorm-stubs and its internal Reflector (for faster patches, to not have to wait on JetBrains's stubs).
I added a lot of issues to the tracker for the symbols I've found:
And meanwhile I'm fixing this on my side in PHP-Scoper.
So about my request: it would be awesome if, as you add a new function to the package, you could double check if the Jetbrains stub exists, and if it doesn't to add an issue about it and ping me, or alternatively just ping me in the PR where you add new symbols, I'm happy to do it as well.
It is but a request, if you think it's too much burden then I'll keep to check all changes to the package and try to triage it. It's just a lot more work 😓
The text was updated successfully, but these errors were encountered:
theofidry
changed the title
Ensure the new symbols are known stubs
Ensure the new symbols are known to stubs
Nov 11, 2023
Hi! This is more of a request rather than a feature/bug.
Recently I included this package in PHP-Scoper and I encountered a few issues... Indeed, PHP-Scoper changes the namespace, and for not breaking globally registered user functions, it aliases the ones it came across with a statement like so:
And turns out there was quite a few symbols for this project! The real issue however, is because PHP-Scoper relies on https://github.com/JetBrains/phpstorm-stubs and its internal Reflector (for faster patches, to not have to wait on JetBrains's stubs).
I added a lot of issues to the tracker for the symbols I've found:
And meanwhile I'm fixing this on my side in PHP-Scoper.
So about my request: it would be awesome if, as you add a new function to the package, you could double check if the Jetbrains stub exists, and if it doesn't to add an issue about it and ping me, or alternatively just ping me in the PR where you add new symbols, I'm happy to do it as well.
It is but a request, if you think it's too much burden then I'll keep to check all changes to the package and try to triage it. It's just a lot more work 😓
The text was updated successfully, but these errors were encountered: