From 6c610b5305adc01fe8421b99974c571948529239 Mon Sep 17 00:00:00 2001
From: akutz <sakutz@gmail.com>
Date: Fri, 11 Nov 2016 14:02:58 -0600
Subject: [PATCH] ScaleIO Get Volumes Attachment States Fix

This patch fixes an issue where the ScaleIO storage driver always
assumed that the local devices information should be available when
inspecting a volume or that a volume's attachment information should
always be fetched.
---
 .../scaleio/storage/scaleio_storage.go        | 36 +++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/storage/scaleio/storage/scaleio_storage.go b/drivers/storage/scaleio/storage/scaleio_storage.go
index 21f08f7b..32c9fd05 100644
--- a/drivers/storage/scaleio/storage/scaleio_storage.go
+++ b/drivers/storage/scaleio/storage/scaleio_storage.go
@@ -164,7 +164,7 @@ func (d *driver) Volumes(
 	opts *types.VolumesOpts) ([]*types.Volume, error) {
 
 	sdcMappedVolumes := make(map[string]string)
-	if opts.Attachments.Requested() {
+	if opts.Attachments.Devices() {
 		if ld, ok := context.LocalDevices(ctx); ok {
 			sdcMappedVolumes = ld.DeviceMap
 		}
@@ -195,8 +195,8 @@ func (d *driver) Volumes(
 			return ""
 		}
 
-		if protectionDomain, ok := mapProtectionDomainName[pool.ProtectionDomainID]; ok {
-			return protectionDomain.Name
+		if pd, ok := mapProtectionDomainName[pool.ProtectionDomainID]; ok {
+			return pd.Name
 		}
 		return ""
 	}
@@ -209,22 +209,22 @@ func (d *driver) Volumes(
 	var volumesSD []*types.Volume
 	for _, volume := range volumes {
 		var attachmentsSD []*types.VolumeAttachment
-		for _, attachment := range volume.MappedSdcInfo {
-			var deviceName string
-			if _, exists := sdcMappedVolumes[volume.ID]; exists {
-				deviceName = sdcMappedVolumes[volume.ID]
-			}
-			instanceID := &types.InstanceID{
-				ID:     attachment.SdcID,
-				Driver: d.Name(),
+		if opts.Attachments.Requested() {
+			for _, attachment := range volume.MappedSdcInfo {
+				instanceID := &types.InstanceID{
+					ID:     attachment.SdcID,
+					Driver: d.Name(),
+				}
+				attachmentSD := &types.VolumeAttachment{
+					VolumeID:   volume.ID,
+					InstanceID: instanceID,
+					Status:     "",
+				}
+				if devName, ok := sdcMappedVolumes[volume.ID]; ok {
+					attachmentSD.DeviceName = devName
+				}
+				attachmentsSD = append(attachmentsSD, attachmentSD)
 			}
-			attachmentSD := &types.VolumeAttachment{
-				VolumeID:   volume.ID,
-				InstanceID: instanceID,
-				DeviceName: deviceName,
-				Status:     "",
-			}
-			attachmentsSD = append(attachmentsSD, attachmentSD)
 		}
 
 		var IOPS int64