"Add link" shown when options "extra" and "max_num" equal 0

[timur-orudzhov]

I've set options for my NestedTabularInline like this:

class PackageItemInline(nested_admin.NestedTabularInline):
model = PackageUnit
extra = 0
max_num = 0

But nothing changed, I still see "add link". Could anyone explain what the problem is ?

[fdintino]

Could you provide some context? What purpose does an inline with max_num = 0 serve?

[timur-orudzhov]

@fdintino when we set max_num=0 and extra=0 for common inlines, "add link" disappear, but for for nested inline it does not work.

[j2kun]

I don't know why this was closed, but it is indeed a bug with this project. max_num = 0 should disable the "add another" button from inlines.

[fdintino]

@j2kun it was closed because 02eb051 should fix this issue. Specifically, this line should cause the add another button to be hidden. Is that not the case for you? Could you share the version of Django you are using, whether you are using any django skins such as grappelli or django-suit, and whether you are doing any other customizations with the admin (e.g. other admin enhancement modules, custom change_form.html template, etc.)

[j2kun]

This is happening for me with a vanilla admin panel for django 1.10. My admin looks roughly like the following, with FooBatch foreign-keying to Foo, which foreign keys to FooContainer.

class FooBatchInline(nested_admin.NestedTabularInline):
    model = FooBatch
    fields = ('created', 'batch_size', 'realized_count')
    readonly_fields = fields
    can_delete = False
    max_num = 0
    extra = 0

    def has_add_permission(self, request):
        return False


class FooInline(nested_admin.NestedTabularInline):
    model = Foo
    fields = (...)
    readonly_fields = fields
    can_delete = False
    extra = 0
    max_num = 0
    classes = ('collapse',)
    inlines = [
        FooBatchInline,
    ]

class FooContainerAdmin(DjangoObjectActions, nested_admin.NestedModelAdmin):
    model = FooContainer
    ...
    inlines = [FooInline]

[j2kun]

(the has add permission was a hailmary)

[fdintino]

Huh, that's weird. I'm having difficulty reproducing. The following are screenshots from running tox -e py27-dj110 -- --selenium=chrome TestTabularInlineAdmin.test_add_item_to_empty (this selenium test); the first is TabularItemInline without a max_num defined, the second with max_num = 0:

[j2kun]

I'll keep looking into it.

[theladyjaye]

Maybe related? I get the add and remove buttons when max_num = 1 but only when deriving from nested_admin.*Inline. If I return to deriving from just admin.StackedInline, for example I don't get any buttons (the expected behavior)