Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partialCached should not be applied to site-navigation.html #173

Closed
phy25 opened this issue May 14, 2019 · 2 comments
Closed

partialCached should not be applied to site-navigation.html #173

phy25 opened this issue May 14, 2019 · 2 comments

Comments

@phy25
Copy link

phy25 commented May 14, 2019

This bug is introduced by #165. site-navigation.html includes i18nlist.html, which is different on every page and should never be cached across pages. This will cause bug that i18n links point to other pages rather than this page.

https://github.com/budparr/gohugo-theme-ananke/blob/389e12c252a4586e925424de5ef039f382e9d18a/layouts/partials/site-navigation.html#L7

If you need a patch I can create one, but it should be very simple and involves layouts/partials/page-header.html and layouts/partials/site-header.html.
@echarp
Copy link
Contributor

echarp commented May 14, 2019

I'm looking into it

@echarp echarp mentioned this issue May 14, 2019
Merged
@phy25
Copy link
Author

phy25 commented May 28, 2019

Closed by #174.

@phy25 phy25 closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phy25 @echarp