Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for react-focus-lock crossFrame prop #72

Closed
cee-chen opened this issue Jun 26, 2023 · 2 comments · Fixed by #73
Closed

Adding support for react-focus-lock crossFrame prop #72

cee-chen opened this issue Jun 26, 2023 · 2 comments · Fixed by #73

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jun 26, 2023 •
edited
Loading

Hey again @theKashey! 👋 We just got a question about iframe behavior from one of our consumers. While I was looking for a solution or workaround, I noticed that react-focus-lock supports a crossFrame prop that was added a few years ago (theKashey/react-focus-lock#104) and would likely be exactly what we need.

Is there any chance we could extend FocusOn to allow the same crossFrame configuration and pass that to FocusLock? 🙏 That would be incredibly helpful to us. Would you accept a PR with this addition?
@cee-chen cee-chen mentioned this issue Jun 26, 2023
Merged
@cee-chen
Copy link
Contributor Author

Thanks again for looking at this so quickly @theKashey! I know you're busy, but any chance you could drop a quick mention in this thread once the new feature has been released to npm? 🙏

@theKashey
Copy link
Owner

Better late than never 😅 3.9.0 has been released.

@cee-chen cee-chen mentioned this issue Jul 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add explicit crossFrame support for ReactFocusLock cee-chen/react-focus-on
2 participants
@cee-chen @theKashey