Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing focusOptions to react-focus-lock #62

Closed
cee-chen opened this issue Oct 26, 2022 · 0 comments · Fixed by #63
Closed

Support passing focusOptions to react-focus-lock #62

cee-chen opened this issue Oct 26, 2022 · 0 comments · Fixed by #63

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Oct 26, 2022

As of 2.7.0, react-focus-lock has supported a focusOptions prop, primarily for allowing consumers to pass preventScroll to the initial focus event. react-focus-on unfortunately has not exposed nor is passing that prop directly to react-focus-lock, which potentially leads to scroll jumping issues that cannot be overridden (see theKashey/react-focus-lock#162 for more info).

It should be relatively trivial to pull focusOptions from props and pass it directly to <ReactFocusLock> here: https://github.com/theKashey/react-focus-on/blob/master/src/UI.tsx#L49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant