-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FocusLock should have cross-frame behavior controllable #104
Comments
IMO the default should be false, as it's surprising this behavior is even possible in the browser |
I think this crossFrame option must be described in the documentation. |
This was referenced May 27, 2022
Updated readme with crossFrame prop - #220 |
This was referenced May 27, 2022
nickspaargaren
pushed a commit
to nickspaargaren/react-focus-lock
that referenced
this issue
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am adding new
crossFrame
option, right now defaults to true, as long as this behaviour might introduce a breaking change for someone.setting crossFrame=true will work "as today". Focus will try to keep focus
setting crossFrame=false will work "as proposed". Iframes would be treated as "pages", and let you move focus outside.
I am not sure which behaviour is actually correct - iframes are usually a part of a page, a part of your product, and the only exemptions are non-production examples like code-sandbox.
The text was updated successfully, but these errors were encountered: