Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of files are skipped and not downloaded #3

Open
FedeAbella opened this issue Aug 21, 2020 · 2 comments
Open

A lot of files are skipped and not downloaded #3

FedeAbella opened this issue Aug 21, 2020 · 2 comments

Comments

@FedeAbella
Copy link

I just tried this out with a Workshop mod (Clank! Scripted, id=912353521), and the script misses a lot of files which are not downloaded. I think it is skipping all urls which are on objects that don't have a CustomMesh property (for example, CustomDeck objects), but this is just after a cursory glance at the script and mod json.

@theFroh
Copy link
Owner

theFroh commented Aug 24, 2020

Spot on, it only looks for CustomMesh (so any mesh data and texture URLs). If you upload a copy of that mod's .json file, I can take a look to see what I need to add to the script to handle more custom object types.

@FedeAbella
Copy link
Author

Sure thing, here you go! Can't really tell you if that covers all possible properties that need urls downloaded, but it's something I guess. Don't really know a lot about these mod jsons, but I'm guessing there must be a reason not to just parse all urls in the json?
912353521.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants