Update mutations_yoch.py #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-vampiire
requested changes
Oct 5, 2018
There was a problem hiding this comment.
hey nice work. thanks for participating.
i think you have it backwards. the goal is to find that all of the letters in the second argument (q) are represented by the first argument (p)
in this case i think both solutions are worth keeping. why dont you create a new solution mutations_Theabominog.py and make a PR for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to rewrite the code for Problem #3 (mutations) using functions that i was more familiar with. Hopefully this is what was expected as i am quite new to this. Thanks for allowing me to participate :)
i took the initial words and converted them all into lowercase and sorted them and then compared the smaller word ensuring that all letters in the smaller word are compared with the larger one