Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draupnir will not join the room after unprotecting and reprotecting a room. #615

Open
ll-SKY-ll opened this issue Oct 27, 2024 · 1 comment
Labels
bug Something isn't working L2 Few Likelihood MPS Follow Up P2 Aggravating Priority level T4 Minor usability Impairs usability in secondary scenarios.

Comments

@ll-SKY-ll
Copy link

ll-SKY-ll commented Oct 27, 2024

Context: https://matrix.to/#/%21IaWNErZAgQUhGqJXjX%3Amatrix.org/%24J3HjChUOSLpSs4r-4ECG4M0FewvWT7EXntxczg0CTN4?via=matrix.org&via=envs.net&via=tchncs.de

Bug appearing on v2.0.0-beta7 and beta8

If i leave a room with !draupnir rooms remove #roomname:server.com and try to rejoin the room via !draupnir rooms add #roomname:server.com, the bot gives me a confirmation in the management room and even says it it Setting the Server ACL since its out of sync but actually never joins the room. If i restart the bot, it immediately joins the room, so i assume that the account data is still correct. I checked out previous versions in git and built them to see where that behaviour started and can say that for me beta 7 and 8 is affected and on beta 6 its working like intended

@Gnuxie
Copy link
Member

Gnuxie commented Oct 27, 2024

developer context: We recently changed the RoomJoiner capability to check the JoinedRoomsRevision before calling /join and to skip joining if the revision says we are already joined. There are two problems that have been confirmed with this issue.

  1. we don't inform the JoinedRoomsRevision properly of parts when running in bot mode.
  2. we don't preemptively update the revision when we leave the protected room. I think that's because we don't have a capability for leaving rooms where we can do that.

@Gnuxie Gnuxie added bug Something isn't working L2 Few Likelihood P2 Aggravating Priority level T4 Minor usability Impairs usability in secondary scenarios. MPS Follow Up labels Oct 27, 2024
@Gnuxie Gnuxie changed the title Unprotecting an reprotecting a room during runtime does not work Draupnir will not join the room after unprotecting and reprotecting a room. Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working L2 Few Likelihood MPS Follow Up P2 Aggravating Priority level T4 Minor usability Impairs usability in secondary scenarios.
Projects
Status: No status
Development

No branches or pull requests

2 participants