Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draupnir should scream if it is started without the explicit --draupnir-config argument, because the legacy modes of starting Draupnir without config are fragile. #218

Closed
Gnuxie opened this issue Jan 24, 2024 · 3 comments
Labels
L2 Few Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss

Comments

@Gnuxie
Copy link
Member

Gnuxie commented Jan 24, 2024

If we haven't already deprecated using the environment variables to select a config, we should now.

We should also verify that Draupnir refuses to start if the path specified with --draupnir-config cannot be found.

Related: #217

@FSG-Cat
Copy link
Member

FSG-Cat commented Jan 24, 2024

Because spantaleev/matrix-docker-ansible-deploy#3128 is merged this change can be made without affecting playbook users that are up to date as of whenever a change like this is made in a negative way.

@Gnuxie
Copy link
Member Author

Gnuxie commented Oct 9, 2024

So to improve the situation we have included

Tue, 08 Oct 2024 11:28:13 GMT [WARN] [Draupnir config] DEPRECATED Starting Draupnir without the --draupnir-config option is deprecated. Please provide Draupnir's configuration explicitly with --draupnir-config. config path used: /home/user/experiments/Draupnir/config/harness.yaml

At startup via #604. Whether this is enough yet we'll figure out

@Gnuxie
Copy link
Member Author

Gnuxie commented Oct 9, 2024

To be honest we should make this log message bigger, probably by putting the Please provide... part on its own line.

@Gnuxie Gnuxie closed this as completed Oct 11, 2024
@github-project-automation github-project-automation bot moved this from Scheduled to Done in Draupnir planning Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L2 Few Likelihood P3 Outrageous / Cannot continue to or start to use Priority level - includes missing documentation leading to same outrage etc T6 Crash Bug causes crash OR data loss
Projects
Status: Done
Development

No branches or pull requests

2 participants