Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unreadable text on dark background #1486

Closed
Juma7C9 opened this issue Mar 10, 2024 · 3 comments
Closed

Unreadable text on dark background #1486

Juma7C9 opened this issue Mar 10, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Juma7C9
Copy link

Juma7C9 commented Mar 10, 2024

Describe the bug
Using a theme with a dark background, a rich-text email with the text color explicitly set to black and no background color set (which seems to be the default on mails sent from Outlook) is unreadable unless the option to remove the text and background colors is selected.

To Reproduce
Steps to reproduce the behavior:

  1. On snappymail set a dark theme and check that the Remove background and text colors from message body option is unchecked;
  2. Open Outlook's webmail and check that the plaint-text option is not enabled;
  3. Compose and send an email with some arbitrary text;
  4. On snappymail open the received message;
  5. Only the non-black portions of the text are clearly visible, while the black text is visible only when selected.

Expected behavior
The text in the received message should be visible, even if the text and reader background color are nearly the same.

Screenshots
If applicable, add screenshots to help explain your problem.

Sample message
Same message with the black text selected

Please complete the following information:

  • Browser: Firefox 123.0.1
  • SnappyMail Version: 2.35.2 on Nextcloud 28.0.3

Additional context

Message source:

--_000_MW4PR84MB1418242A1C4C8F6D6C1F060FB7252MW4PR84MB1418NAMP_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

black text
red text

--_000_MW4PR84MB1418242A1C4C8F6D6C1F060FB7252MW4PR84MB1418NAMP_
Content-Type: text/html; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
1">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div class=3D"elementToProof"><span style=3D"font-family: Aptos, Aptos_Embe=
ddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 1=
2pt; color: rgb(0, 0, 0);">black text</span></div>
<div class=3D"elementToProof"><span style=3D"font-family: Aptos, Aptos_Embe=
ddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 1=
2pt; color: rgb(237, 92, 87);">red text</span></div>
</body>
</html>

--_000_MW4PR84MB1418242A1C4C8F6D6C1F060FB7252MW4PR84MB1418NAMP_--
@the-djmaze
Copy link
Owner

the-djmaze commented Mar 11, 2024 •
edited
Loading

You should report the bug to Outlook, not in here.
The option to remove colors works great.
Converting colors is way to complicated to "fix".
As using filter: invert(100%); has other side effects.

@the-djmaze the-djmaze closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
@Juma7C9
Copy link
Author

Juma7C9 commented Mar 12, 2024

I'm not sure how other clients manage this situation, but could it be a good idea to add an option to have a white background for the viewer, regardless of the theme -- at least for rich-text messages?

@the-djmaze the-djmaze added the enhancement New feature or request label Mar 12, 2024
@the-djmaze
Copy link
Owner

the-djmaze commented Mar 12, 2024 •
edited
Loading

could it be a good idea to add an option to have a white background for the viewer

Now that is an idea 😉

"good" depends on who you ask, but maybe make it a toggle in the menu?
afbeelding
Things like:

  • light background
  • dark background
  • invert colors
  • remove colors

As the same applies to people who use dark-mode and write text in white and then someone with a white screen can't read it.

@the-djmaze the-djmaze reopened this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@the-djmaze @Juma7C9