From 5cba97de699d79ddf7f223b2f22bb96974c3d6a3 Mon Sep 17 00:00:00 2001 From: miguel-real-miei <91724877+miguel-real-miei@users.noreply.github.com> Date: Tue, 23 Nov 2021 18:13:45 +0000 Subject: [PATCH] Update code_smells_56773_reviewlog.txt The task associated with the reviewed code smell detailed in the reviewlog is "Code Smell #3". --- .../team_member_56773/code_smells_56773_reviewlog.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Project/Phase 1/Sprint 1/team_member_56773/code_smells_56773_reviewlog.txt b/Project/Phase 1/Sprint 1/team_member_56773/code_smells_56773_reviewlog.txt index 8504a2e18d7..d5a870a9c7a 100644 --- a/Project/Phase 1/Sprint 1/team_member_56773/code_smells_56773_reviewlog.txt +++ b/Project/Phase 1/Sprint 1/team_member_56773/code_smells_56773_reviewlog.txt @@ -1,3 +1,7 @@ -Team Meber 56971, João Vieira: +Team Member 56971, João Vieira: Regarding Long Parameter List: "Yes I agree that parameter lists of these 3 constructors are too long, I also think both your proposed fixes will probably be necesserary in some cases. For example in the GuiPreferences.java constructor, even if we bundle the position and size parameters into its own class, we will still have a paramters list of size 6, which is still too long." + +Team Member 55677, Miguel Real: + Regarding Comments/Dead Code: + "It seems the developers taking care of this feature may have forgotten about the commented code, which is an unfortunate but common problem in larger projects. I agree with the problem itself and the proposed solution, and mark this task as Complete."