This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
json-rpc server should always use local rpc client #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
Closes: evmos#987 Solution: - use local rpc clint if json-rpc is enabled.
fedekunze
approved these changes
Mar 14, 2022
|
@yihuang can you fix the rpc tests? |
it seems not related to the PR, can you re-run it, maybe due to non-deterministicity? |
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Mar 22, 2022
Closes: evmos#987 Solution: - use local rpc clint if json-rpc is enabled. Co-authored-by: Federico Kunze Küllmer <[email protected]>
yihuang
added a commit
to yihuang/ethermint
that referenced
this pull request
Mar 24, 2022
Closes: evmos#987 Solution: - use local rpc clint if json-rpc is enabled. Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #987
Solution:
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)