Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Validate code hash in GenesisAccount #873

Merged
merged 2 commits into from
Jan 4, 2022

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jan 4, 2022

Closes: #872

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #873 (225430b) into main (7c53e32) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
+ Coverage   57.43%   57.46%   +0.02%     
==========================================
  Files          74       74              
  Lines        6153     6157       +4     
==========================================
+ Hits         3534     3538       +4     
  Misses       2408     2408              
  Partials      211      211              
Impacted Files Coverage Δ
x/evm/genesis.go 51.66% <100.00%> (+3.45%) ⬆️

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, pending changelog entry

@yihuang yihuang force-pushed the validate-code-hash branch from 19747e8 to 225430b Compare January 4, 2022 13:15
@yihuang
Copy link
Contributor Author

yihuang commented Jan 4, 2022

ACK, pending changelog entry

done

@fedekunze fedekunze merged commit 8e4ff5a into evmos:main Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate code hash in GenesisAccount
2 participants