Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Clear access list for each transaction #802

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Nov 30, 2021

Closes: #801

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, can you add a changelog entry

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #802 (eadd27a) into main (e6d0eff) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
+ Coverage   57.23%   57.29%   +0.06%     
==========================================
  Files          73       73              
  Lines        6021     6030       +9     
==========================================
+ Hits         3446     3455       +9     
  Misses       2375     2375              
  Partials      200      200              
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 77.12% <100.00%> (+0.15%) ⬆️
x/evm/keeper/statedb.go 73.59% <100.00%> (+0.33%) ⬆️

@yihuang
Copy link
Contributor Author

yihuang commented Nov 30, 2021

ACK, can you add a changelog entry

done

@fedekunze fedekunze added the automerge Automatically merge PR once all prerequisites pass. label Nov 30, 2021
@fedekunze fedekunze enabled auto-merge (squash) November 30, 2021 10:28
@fedekunze fedekunze disabled auto-merge November 30, 2021 11:35
@fedekunze fedekunze merged commit 3b0fa63 into evmos:main Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

access list is not cleared for each transaction
2 participants