This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davcrypto
requested review from
fedekunze and
khoslaventures
as code owners
September 16, 2021 02:50
Visit https://dashboard.github.orijtech.com?back=0&pr=566&remote=true&repo=davcrypto%2Fethermint to see benchmark details. |
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 53.39% 52.72% -0.68%
==========================================
Files 64 64
Lines 5128 5233 +105
==========================================
+ Hits 2738 2759 +21
- Misses 2263 2320 +57
- Partials 127 154 +27
|
fedekunze
suggested changes
Sep 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good in general, but the error is not cleared anywhere (I only see it on the test).
Can you also add a changelog entry under Improvements? 🙏
Co-authored-by: Federico Kunze Küllmer <[email protected]>
Thanks @fedekunze for the review. Made some update and explanation according to the your comments. Lets discuss on it |
fedekunze
reviewed
Sep 16, 2021
fedekunze
approved these changes
Sep 17, 2021
fedekunze
added
the
automerge
Automatically merge PR once all prerequisites pass.
label
Sep 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #410
Description
Introduce stateErr fields into keeper so that stateDB functions enabled ability to detect previous error
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)