Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

logIndex should be set to the index in the block rather than tx #334

Closed
yihuang opened this issue Jul 21, 2021 · 0 comments · Fixed by #354
Closed

logIndex should be set to the index in the block rather than tx #334

yihuang opened this issue Jul 21, 2021 · 0 comments · Fixed by #354
Assignees
@yihuang

Comments

@yihuang
Copy link
Contributor

yihuang commented Jul 21, 2021

System info: ethermint main branch

Steps to reproduce:

https://github.com/tharsis/ethermint/blob/main/x/evm/keeper/statedb.go#L595

Expected behavior: log.Index should be set to the index of log in the whole block

Actual behavior: log.Index is set to the index of log in the tx

Additional info:
go-ethereum: https://github.com/ethereum/go-ethereum/blob/master/core/state/statedb.go#L190
@yihuang yihuang changed the title logIndex should be log index in block rather than in tx logIndex should be set to the index in the block rather than tx Jul 21, 2021
@yihuang yihuang self-assigned this Jul 21, 2021
@yihuang yihuang mentioned this issue Jul 26, 2021
Merged
11 tasks
yihuang referenced this issue in yihuang/ethermint Jul 26, 2021
@yihuang
chaneg log index to the index in block
d0509a7 
Closes #334
fedekunze pushed a commit that referenced this issue Jul 26, 2021
@yihuang
evm: change log tx index to index in block (#354)
5458126 
Closes #334
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chaneg log index to the index in block yihuang/ethermint
1 participant
@yihuang