Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Update GetGasPrice RPC endpoint with global MinGasPrice #1108

Merged
merged 5 commits into from
Jun 3, 2022

Conversation

crypto-facs
Copy link
Contributor

Description

This PR aims to update GetGasPrice API with the new GlobalMinGasPrice module param. The idea is to return this value as minimum for transactions to adjust to the new decorator.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@crypto-facs crypto-facs changed the title Get gas rpc Update GetGasPrice RPC endpoint with global MinGasPrice Jun 2, 2022
Copy link
Contributor

@loredanacirstea loredanacirstea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you update the changelog too? 🙏

rpc/backend/evm_backend.go Show resolved Hide resolved
rpc/namespaces/ethereum/eth/api.go Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) June 3, 2022 13:26
@fedekunze fedekunze merged commit da99f11 into evmos:main Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants