This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
impr(evm): add tx_type, gas and counter telemetry for ethereum txs #1101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-381 Observability (telemetry) on Ethermint
reimplement https://github.com/tharsis/ethermint/pull/545/files without |
danburck
requested review from
fedekunze,
khoslaventures and
jolube
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1101 +/- ##
==========================================
+ Coverage 59.39% 59.52% +0.13%
==========================================
Files 85 85
Lines 6992 7015 +23
==========================================
+ Hits 4153 4176 +23
Misses 2622 2622
Partials 217 217
|
crypto-facs
approved these changes
May 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds telemetry for Ethereum txs. This functionality was originally removed with https://github.com/tharsis/ethermint/pull/545/files because of performance issues with
telemetry.ModuleMeasureSince, which are not readded.