Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

use sdk.Int for TxData's chain-id and amount #207

Closed
fedekunze opened this issue Jun 29, 2021 · 0 comments · Fixed by #208
Closed

use sdk.Int for TxData's chain-id and amount #207

fedekunze opened this issue Jun 29, 2021 · 0 comments · Fixed by #208
Assignees
@fedekunze
Labels
C:x/evm EVM module

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Jun 29, 2021 •
edited
Loading

Now that the SDK version supports the max ERC20 value (cosmos/cosmos-sdk#9511), we should update the proto message fields from TxData to use sdk.Int instead of plain bytes.

We should also update any relevant validation functions

Scope:

  • Update proto message
  • Update validation functions, constructors, etc
  • Remove (Un)MarshalBigInt funcs from types/
@fedekunze fedekunze added good first issue Good for newcomers C:x/evm EVM module labels Jun 29, 2021
@fedekunze fedekunze self-assigned this Jun 29, 2021
@fedekunze fedekunze removed the good first issue Good for newcomers label Jun 29, 2021
@fedekunze fedekunze mentioned this issue Jun 29, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fedekunze fedekunze

Labels
C:x/evm EVM module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use sdk.Int for TxData evmos/ethermint
1 participant
@fedekunze