Compactor/Store Gateway/Bucket UI: Enable finding overlapping block make frontend crash

[antonincms]

Thanos, Prometheus and Golang version used:

• Thanos quay.io/thanos/thanos:v0.25.2
• Thanos quay.io/thanos/thanos:v0.26.0
• Thanos quay.io/thanos/thanos:v0.27.0
• ...
• Thanos quay.io/thanos/thanos:v0.36.0

Object Storage Provider:

AWS S3

What happened:

On the frontend using google chrome, on the loaded blocks page when ticking the Enable finding overlapping block ...

On google chrome I get the error

TypeError: Cannot read properties of undefined (reading 'thanos')
    in t
    in L
    in j
    in x
    in j
    in div
    in h
    in n
    in Da

and on firefox I get :

TypeError: i[0][0] is undefined
    in t
    in L
    in j
    in x
    in j
    in div
    in h
    in n
    in Da

Full logs to relevant components:

Compactor logs filtered by component=bucketUI :

level=warn ts=2022-05-12T12:27:10.72680398Z caller=ui.go:204 component=bucketUI msg="Could not get file" err="AssetInfo pkg/ui/static/react/static/js/main.eec2650e.chunk.js.map not found" file=pkg/ui/static/react/static/js/main.eec2650e.chunk.js.map
level=warn ts=2022-05-12T12:27:10.68813083Z caller=ui.go:204 component=bucketUI msg="Could not get file" err="AssetInfo pkg/ui/static/react/static/js/2.f69d72f3.chunk.js.map not found" file=pkg/ui/static/react/static/js/2.f69d72f3.chunk.js.map
level=warn ts=2022-05-12T12:27:10.787708375Z caller=ui.go:204 component=bucketUI msg="Could not get file" err="AssetInfo pkg/ui/static/react/static/css/main.e128754d.chunk.css.map not found" file=pkg/ui/static/react/static/css/main.e128754d.chunk.css.map
level=warn ts=2022-05-12T12:27:10.748746088Z caller=ui.go:204 component=bucketUI msg="Could not get file" err="AssetInfo pkg/ui/static/react/static/css/2.3288c2bf.chunk.css.map not found" file=pkg/ui/static/react/static/css/2.3288c2bf.chunk.css.map

Anything else we need to know:

[pippitt]

Same issue, hopefully helpful data from chrome dev tools console

2.f69d72f3.chunk.js:2 TypeError: Cannot read properties of undefined (reading 'thanos')
    at main.eec2650e.chunk.js:1:142741
    at Array.map (<anonymous>)
    at main.eec2650e.chunk.js:1:142604
    at main.eec2650e.chunk.js:1:142809
    at Object.ga [as useMemo] (2.f69d72f3.chunk.js:2:1220063)
    at t.useMemo (2.f69d72f3.chunk.js:2:1157829)
    at main.eec2650e.chunk.js:1:142539
    at Jo (2.f69d72f3.chunk.js:2:1216397)
    at Wa (2.f69d72f3.chunk.js:2:1225289)
    at ws (2.f69d72f3.chunk.js:2:1263796)
is @ 2.f69d72f3.chunk.js:2
Os.o.componentDidCatch.n.callback @ 2.f69d72f3.chunk.js:2
vo @ 2.f69d72f3.chunk.js:2
us @ 2.f69d72f3.chunk.js:2
Oc @ 2.f69d72f3.chunk.js:2
t.unstable_runWithPriority @ 2.f69d72f3.chunk.js:2
Ui @ 2.f69d72f3.chunk.js:2
Mc @ 2.f69d72f3.chunk.js:2
sc @ 2.f69d72f3.chunk.js:2
(anonymous) @ 2.f69d72f3.chunk.js:2
t.unstable_runWithPriority @ 2.f69d72f3.chunk.js:2
Ui @ 2.f69d72f3.chunk.js:2
Qi @ 2.f69d72f3.chunk.js:2
Gi @ 2.f69d72f3.chunk.js:2
(anonymous) @ 2.f69d72f3.chunk.js:2
j @ 2.f69d72f3.chunk.js:2
W @ 2.f69d72f3.chunk.js:2
I @ 2.f69d72f3.chunk.js:2
Zt @ 2.f69d72f3.chunk.js:2
Jt @ 2.f69d72f3.chunk.js:2
t.unstable_runWithPriority @ 2.f69d72f3.chunk.js:2
Ui @ 2.f69d72f3.chunk.js:2
P @ 2.f69d72f3.chunk.js:2
Qt @ 2.f69d72f3.chunk.js:2

[yeya24]

Got the same issue.

[mfilocha]

Same for 0.26.0

[Birckof]

+1, same error

[SKUndef]

+1

[mattsmith47988]

+1

[shanaider]

same this error on image: thanos:0.27.0 and chrome browser

[hsolberg]

Same error using Chrome version 105.0.5195.52 (Official Build) (64-bit) with the latest Thanos version.

Thanos Build Information

Version	Revision
0.28.0	7f58065

TypeError: Cannot read properties of undefined (reading 'thanos')
    in t
    in be
    in xe
    in it
    in mt
    in div
    in F
    in n
    in ND

[GreenRover]

+1

[matej-g]

Yeah, hit this today as well, this should not be a big issue to fix

[fredpan]

Same problem... Any solution?

[bmgante]

Same problem here. Any solution on this?

[pie-r]

Same in 0.29.0

[caoimheharvey]

Same in 0.31.0

[awcodify]

Any updates?
Also happened in 0.30.2

[samsung-cnct-bot]

This issue is severely impacting me

[imgfrost]

would love this to get resolved, having a massive issue with overlapping blocks, so having a UI that would show this would be ideal.

[mortaelth]

same in 0.32.3

[aslafy-z]

I implemented a potential fix at #6768, but have no overlapping blocks in my thanos instances. Can someone with overlapping blocks try it? @imgfrost maybe?
I pushed an amd64 docker image based on the main branch at docker.io/zadki3l/thanos:0.32-fix-overlapping-blocks

[hayk96]

@aslafy-z seems it's the same. Didn't work for me. I had a problem related to the overlapped blocks and couldn't find them by using the image docker.io/zadki3l/thanos:0.32-fix-overlapping-blocks.

[aslafy-z]

@hayk96 @wiardvanrij @imgfrost @hsolberg can you please try again? I added the compiled source to the docker image. docker.io/zadki3l/thanos@sha256:d11e4dfa1de67040d4fef935e7bd6340d95c00efb0b56c8e7da709b4682fb986

[m5lapp]

Thanks @aslafy-z, I gave it a try and it does seem to detect overlapping blocks successfully:

[MosesMooreGameloft]

thanos 0.32.5, rev 750e8a94eed5226cd4562117295d540a968c163c, BuildDate 20231019-04:21:44, GoVersion go1.21.3

Talking to each of the webUI for thanos-store, thanos-compact or thanos-bucket, when I click on [ ] Enable find overlapping blocks I get:
"Aaaah! Something went wrong. Please file an issue in the Thanos issue tracker."

TypeError: Cannot read properties of undefined (reading 'thanos')
    in t
    in be
    in xe
    in it
    in mt
    in div
    in F
    in n
    in PD

I see there's already issues here, hope adding a comment satisfies the "Please file an issue" instruction.

[atobaum]

same in v0.34.1

[jumakasy]

same in v.0.36.0

[pureiboi]

I have added a fix. I have tested with my object store in S3 bucket.

Seems to be working for me.

Someone might want to verify the same

[GiedriusS]

Fixed in #7644

[BourgoisMickael]

I see the fix is in unreleased, could you patch as well previous versions, like make a 0.34.2