Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional query stats parameter #4170

Closed
yeya24 opened this issue May 4, 2021 · 1 comment · Fixed by #4176
Closed

Support optional query stats parameter #4170

yeya24 opened this issue May 4, 2021 · 1 comment · Fixed by #4176
Labels
component: query difficulty: easy good first issue help wanted

Comments

@yeya24
Copy link
Contributor

yeya24 commented May 4, 2021

Is your proposal related to a problem?

(Write your answer here.)

Prometheus instant query and range query APIs support an optional stats field to return the timing stats of the executed query.

Thanos should implement the same functionality. For implementation, please check the code in Prometheus:
https://github.com/prometheus/prometheus/blob/main/web/api/v1/api.go#L466-L470
https://github.com/prometheus/prometheus/blob/main/web/api/v1/api.go#L387-L391

Describe the solution you'd like

(Describe your proposed solution here.)

Describe alternatives you've considered

(Write your answer here.)

Additional context

(Write your answer here.)
@someshkoli someshkoli mentioned this issue May 4, 2021
Merged
2 tasks
@ranulf10
Copy link

ranulf10 commented May 5, 2021

@AseR <transferencia ``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: query difficulty: easy good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

querier: Adds additional stats field in query api someshkoli/thanos
2 participants
@yeya24 @ranulf10