Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos Frontend Dashboard styles and .js broken in 0.15.0 #3224

Closed
clausa20 opened this issue Sep 24, 2020 · 12 comments
Closed

Thanos Frontend Dashboard styles and .js broken in 0.15.0 #3224

clausa20 opened this issue Sep 24, 2020 · 12 comments

Comments

@clausa20
Copy link

Hello,

I have thanos deployed with kubernetes. I have querier pods plus a kubernetes service in the front. I have this option so I can access it externally through that service: - --web.external-prefix=/api/v1/namespaces/devenv/services/thanos-querier:http/proxy
without --web.route-prefix
with version 0.14.0 I can access to Thanos Querier Dashboad OK,

but when I update it to version 0.15.0 I cannot access to querier. But if I add this option --web.route-prefix=/ I can access
but all the style is broken in the Dashboard.
Looking into inspect of browser I can see for example this for most of files:

http://api/v1/namespaces/devenv/services/thanos-querier:http/proxy/static/vendor/js/jquery-3.5.0.min.js?v=fbd14b49f95e7543883fedf9381a21127d4dda2b

You can notice that it does not has the host:port after the http://

Only for 2 I see it correctly, for example:
http://localhost:9999/api/v1/namespaces/devenv/services/thanos-querier:http/proxy/graph

Has something changed in version 0.15.0 related to this?

Regards.

@aribalam
Copy link
Contributor

@clausa20 Would you be able to specify how exactly to reproduce the issue. This might help us to know where to look.

@clausa20
Copy link
Author

I just start thanos with kubernetes and a service, then I start a kubectl proxy --port=9999 and I try to browse it.
I see there is another Bug just raised, seems to be the same problem: #3226

@onprem
Copy link
Member

onprem commented Sep 26, 2020

The PR to fix #3226 has been merged. Can you check if this bug still exists if you use a binary built from master.

@clausa20
Copy link
Author

@prmsrswt seems that querier is fixed now, but the thanos frontend fails. It has in the path like double web.external-prefix, one to the frontend and other to the querier, I don't know if that is correct, but I get a Page Not Found 404:

http://localhost:9999/api/v1/namespaces/devenv/services/thanos-frontend:http/proxy/api/v1/namespaces/devenv/services/thanos-querier:http/proxy/graph

@onprem
Copy link
Member

onprem commented Sep 28, 2020

I think you wouldn't need to specify the external prefix like path two times, as query front-end is running inside the cluster, it can access the querier on its regular path instead of the kube-proxy one.

@clausa20
Copy link
Author

@prmsrswt I just put http://localhost:9999/api/v1/namespaces/devenv/services/thanos-frontend:http/proxy/ in the browser, but Thanos adds automatically the api/v1/namespaces/devenv/services/thanos-querier:http/proxy/graph part, like attaching the thanos-querier web.external-prefix . That makes it break I guess.

@clausa20 clausa20 changed the title Thanos querier Dashboard styles and .js broken in 0.15.0 Thanos Frontend Dashboard styles and .js broken in 0.15.0 Sep 30, 2020
@clausa20
Copy link
Author

@prmsrswt I have changed the title, since you already fixed the querier, but the Frontend Dashboard keeps failing.
I see there are many issues raised related to Dashboard access, seems to be all related.

@clausa20
Copy link
Author

clausa20 commented Oct 7, 2020

some news about this?

@yeya24
Copy link
Contributor

yeya24 commented Oct 21, 2020

Can you please try the new v0.16.0 release?

@stale
Copy link

stale bot commented Dec 20, 2020

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label Dec 20, 2020
@stale
Copy link

stale bot commented Jan 4, 2021

Closing for now as promised, let us know if you need this to be reopened! 🤗

@stale stale bot closed this as completed Jan 4, 2021
@yeya24
Copy link
Contributor

yeya24 commented Jan 4, 2021

Hi @clausa20 , Is this fixed or still a problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants