You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When nil error is passed to updateStoreStatus(store *storeRef, err error) results in a nil pointer here status.LastError = &stringError{originalErr: err}
I've got a PR that i've tried to unit tests the entire function so should catch this.
I do not know all the details of how this worked before, I can only assume that *MOST of the errors that get passed to this will have custom Marshal methods, and this fix was to catch those errors that do not, as these will normally Marshal to {}.
Let me know if I've mis understood this.
The text was updated successfully, but these errors were encountered:
Thanos v0.14.0-rc.0
When query is connected to a healthy Store, viewing /stores shows
accessing /api/v1/stores causes a panic.
Issue was introduced in #2809.
When nil error is passed to
updateStoreStatus(store *storeRef, err error)
results in a nil pointer herestatus.LastError = &stringError{originalErr: err}
I've got a PR that i've tried to unit tests the entire function so should catch this.
I do not know all the details of how this worked before, I can only assume that *MOST of the errors that get passed to this will have custom Marshal methods, and this fix was to catch those errors that do not, as these will normally Marshal to {}.
Let me know if I've mis understood this.
The text was updated successfully, but these errors were encountered: