-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gossip from Dashboards and benchmark tool #1180
Comments
I would like to work on this. |
@alexissellier awesome, let me know if you need any help |
@alexissellier Are you still working on this? If not, I'd like to take this. |
Go ahead, I still have not internet yet at home due to relocation so I cannot work on it atm |
Hi @povilasv . Currently I am working on this, but I am quite confused about this function https://github.com/improbable-eng/thanos/blob/2dadd9caa73343d043bc43062fa8e6a32bac1d9e/benchmark/cmd/thanosbench/resources.go#L497. What is this image? Is it thanos-querier? Do I have to change this? Containers: []v1.Container{{
Name: "querier",
//TODO(domgreen): move this to the same repository as Thanos
Image: "eu.gcr.io/io-crafty-shelter/thanos-querier:latest",
Args: []string{
"--host=" + endpoint,
"--queries=" + queries,
"--range-offset-start=" + opts.queryRangeOffsetStart.String(),
"--range-offset-end=" + opts.queryRangeOffsetEnd.String(),
"--query-time=" + opts.queryTime.String(),
"--server=true",
},
}}, |
@domgreen might know more :) |
Sorry @yeya24 for delay. This is some leaked image, you don't need to worry about this now. Let's focus on dashboards only now (: |
Sorry for the delay @bwplotka . But I am considering is it necessary to maintain the dashboard in this repo? IMO it is better to use https://github.com/metalmatze/kube-thanos. WDYT @bwplotka , do we need to add a doc about that? |
Yes, I think the link or even repo in Thanos-io org would be nice indeed |
Agree. /cc @metalmatze |
We should remove gossip info from the example Grafana dashboards and the benchmark/cmd/thanosbench/*.
The text was updated successfully, but these errors were encountered: