-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixes for new arch on RN 74 #473
fix: fixes for new arch on RN 74 #473
Conversation
Thanks for this! What does this do for older versions? Will they break? |
On new arch it will for sure. On paper I think those files are not compiled so it should not. |
I think last time we published this as a pre-release, and then waited until it fully drops to publish in full |
Yes, we can do pre-release, I'm fine breaking back compat for new arch still. |
So let's do it please, it will help with testing it in other libs which use SAC 🚀 |
Looks like this will cause issues even with new arch disabled. The ci build on android fails with old arch and rn 0.73. We will need to find a way to make this backwards compatible. Maybe we can just not compile those classes with some preprocessor macros when on old arch. |
Yeah, it seems not right that you are trying to compile shadow nodes on old arch. |
Ok it seems that you are building new arch in both flows now:
|
Ok old arch builds correctly now and new arch does not build since it is not compatible with RN 0.73, so it looks ready 🚀 |
Thanks! Released as 4.10.0-rc.0 |
Summary
This PR aligns the code with newest version of
yoga
in RN0.74.0-rc.0
. Made with huge help from @piaskowykTest Plan