Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded version to 3.1.0 #20

Closed
wants to merge 2 commits into from
Closed

Upgraded version to 3.1.0 #20

wants to merge 2 commits into from

Conversation

vishalsingh2972
Copy link

solves #19

@vishalsingh2972
Copy link
Author

@th-schwarz can you review this PR!

@th-schwarz th-schwarz self-requested a review July 23, 2023 10:04
@th-schwarz
Copy link
Owner

Sorry, your commits a wrong. If you want to update spring-boot you should NOT add spring-boot as additional dependency, you have to change the version of the parent-pom. And you should not explicit set versions of dependencies, which are managed by spring-boot (e.g. jackson).
If you set the version correct, you'll see some compile errors in SecurityConfig, which has to fix!

@@ -75,6 +75,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
<version>3.1.0</version>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalsingh2972 never add versions to dependencies, which mansged by spring boot itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants