Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of remnants of electron.remote #966

Closed
Araxeus opened this issue Jan 13, 2023 · 0 comments · Fixed by #1113
Closed

Get rid of remnants of electron.remote #966

Araxeus opened this issue Jan 13, 2023 · 0 comments · Fixed by #1113

Comments

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 13, 2023

1. EDIT: fixed by #1113

$ rg electron.remote --no-ignore
node_modules\electron-debug\node_modules\electron-is-dev\index.js
8: const app = electron.app || electron.remote.app;
$ npm why electron-is-dev
[email protected]
node_modules/electron-is-dev
  electron-is-dev@"^0.3.0" from [email protected]
  node_modules/electron-is
    electron-is@"^3.0.0" from the root project

[email protected]
node_modules/electron-debug/node_modules/electron-is-dev
  electron-is-dev@"^1.1.0" from [email protected]
  node_modules/electron-debug
    electron-debug@"^3.2.0" from the root project

[email protected]
node_modules/electron-unhandled/node_modules/electron-is-dev
  electron-is-dev@"^2.0.0" from [email protected]
  node_modules/electron-unhandled
    electron-unhandled@"^4.0.1" from the root project

Fixes:

  1. Remove electron-debug, it's actually useless, its features are part of electron by default

  2. Replace electron-is with a custom inbuilt one using ipc.invoke for front access

    • is.portable() = !!process.env.PORTABLE_EXECUTABLE_DIR
    • is.dev() = !app.isPackaged() / process.defaultApp (same thing)

2. EDIT: fixed by #976

$ rg electron.remote --no-ignore
node_modules\got\source\request-as-event-emitter.js
74: fn = electron.net || electron.remote.net;
$ npm why got
[email protected]
node_modules/got
  got@"^9.6.0" from [email protected]
  node_modules/package-json
    package-json@"^6.3.0" from [email protected]
    node_modules/latest-version
      latest-version@"^5.1.0" from [email protected]
      node_modules/update-notifier
        update-notifier@"^5.1.0" from [email protected]
        node_modules/electron-builder
          dev electron-builder@"^23.0.3" from the root project

Fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant