Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblock Plugin not working on Windows 10 #837

Closed
BaconCatBug opened this issue Sep 19, 2022 · 10 comments · Fixed by #1100
Closed

Adblock Plugin not working on Windows 10 #837

BaconCatBug opened this issue Sep 19, 2022 · 10 comments · Fixed by #1100

Comments

@BaconCatBug
Copy link

image
image

@TheBossMagnus
Copy link

I think I have the same issue. It's somehow related to the "resume last song when app start" being enabled.
It should be fixed with #583 , but I still have this issue

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 11, 2023

I have an experimental faster adblocker here: https://github.com/Araxeus/youtube-music/tree/experimental-faster-adblocker

Looking for people to test it (I don't get any ads with it enabled, but that might be just luck since they are pretty rare for me)

@TheBossMagnus
Copy link

TheBossMagnus commented Jan 13, 2023

I have an experimental faster adblocker here: https://github.com/Araxeus/youtube-music/tree/experimental-faster-adblocker

Looking for people to test it (I don't get any ads with it enabled, but that might be just luck since they are pretty rare for me)

Could you compile and release it?

@Zo-Bro-23
Copy link
Contributor

I have an experimental faster adblocker here: https://github.com/Araxeus/youtube-music/tree/experimental-faster-adblocker
Looking for people to test it (I don't get any ads with it enabled, but that might be just luck since they are pretty rare for me)

Could you compile and release it?

Release available here.

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 13, 2023

Thank you @Zo-Bro-23 !

I see that you committed a special manual release workflow, neat. I might copy it 😁

Just a question: in what way does it differ from build.yml?
I haven't had time to look through the workflow but I assume there are some critical differences?

@TheBossMagnus
Copy link

I have an experimental faster adblocker here: https://github.com/Araxeus/youtube-music/tree/experimental-faster-adblocker

Looking for people to test it (I don't get any ads with it enabled, but that might be just luck since they are pretty rare for me)

Never had any Ads in around 12h of usage, but some weird issues happened: One time audio was in a horrible quality(really distorted), another songs ware skipping 10-30s sections every 5-10 second. Both time close and reopen fixed everything...

@Zo-Bro-23
Copy link
Contributor

another songs ware skipping 10-30s sections every 5-10 second

That might be because of the skip-silences plugin. Is that enabled?

@TheBossMagnus
Copy link

TheBossMagnus commented Jan 17, 2023

another songs ware skipping 10-30s sections every 5-10 second

That might be because of the skip-silences plugin. Is that enabled?

Yes, but never had this issue before with this plugin enabled

@Araxeus
Copy link
Collaborator

Araxeus commented Feb 24, 2023

@Zo-Bro-23 Your release has 37 downloads but we have almost no feedback except the one comment by Magnus

can you edit the description at https://github.com/Zo-Bro-23/youtube-music/releases/tag/v1.19.0 so that it instructs users to report how it works for them at #1040 (or some other centralized place)

@Zo-Bro-23
Copy link
Contributor

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants