Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album cover label on Discord off by one #744

Closed
etomasic opened this issue Jun 9, 2022 · 9 comments · Fixed by #1032
Closed

Album cover label on Discord off by one #744

etomasic opened this issue Jun 9, 2022 · 9 comments · Fixed by #1032

Comments

@etomasic
Copy link

etomasic commented Jun 9, 2022

With the Discord rich presence, the name of the album when hovering the cover displays the previous song's album.
ex

@Araxeus
Copy link
Collaborator

Araxeus commented Jun 9, 2022

Works fine for me, does this happen every time for you or just occasionally?

@etomasic
Copy link
Author

etomasic commented Jun 9, 2022

Yes, it seems to happen every time. The first song in the queue works fine though, presumably because there's no previous song.

@KawaiiTemDev
Copy link

KawaiiTemDev commented Nov 11, 2022

image
Same issue here; only occurs when in autoplay.

@iliqiliev
Copy link

I get this constantly on Linux too

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 16, 2023

The album name is the only thing that is captured through dom elements instead of through youtube api (because it doesn't seem to exist there)

So probably somehow on your pc's album name in the dom gets updated late

Not quite sure how to fix it for you

Dev note: a listener that sends new songInfo when album element is updated is possible, could use the new songInfo 'cause' parameter to avoid breaking other plugins

@ArgoWarsmith
Copy link

Hi everyone. Is there a way to disable the hover over feature? I also have this glitch. Thank you.

@Zo-Bro-23
Copy link
Contributor

Currently, no, but it's probably easy to implement. I currently don't have much free time on my hands though (unfortunately), so would @Araxeus or @xhayper like to take it up?

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 26, 2023

Well if you read my last comment, I have a solution in mind. But it requires #946 to be merged first (like many other things I think about doing 😝)

@Araxeus
Copy link
Collaborator

Araxeus commented Jan 28, 2023

btw here are 2 other ways to get the album name:

navigator.mediaSession.metadata.album
$('ytmusic-player-page').getState().playerPage.playerOverlay.playerOverlayRenderer.browserMediaSession.browserMediaSessionRenderer.album.runs[0].text

They both seems to be slower than the current implementation (somehow it's updated in the DOM text first)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants