Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: (Synced Lyrics) In some unknown conditions, lyrics doesn't display even if lyrics exists and found on LRCLIB. #2332

Closed
3 of 5 tasks
Dzheremi2 opened this issue Aug 4, 2024 · 17 comments · Fixed by #2343

Comments

@Dzheremi2
Copy link
Contributor

Dzheremi2 commented Aug 4, 2024

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I understand that th-ch/youtube-music has NO affiliation with Google or YouTube

YouTube Music (Application) Version

3.5.1

Checklists

What operating system are you using?

Other Linux

Operating System Version

Fedora 40, kernel: 6.9.12-200.fc40.x86_64

What CPU architecture are you using?

x64

Last Known Working YouTube Music (Application) version

No response

Reproduction steps

  1. Play song
  2. Open lyrics tab
    2.1 Lyrics not displayed
  3. Open DevTools > Network and find "search?*" request

Expected Behavior

Lyrics displayed

Actual Behavior

"No lyrics found for this song"
See in additional information attached files

Enabled plugins

  1. Downloader
  2. In-app menu
  3. Precise volume
  4. Shortcuts (and MPRIS)
  5. Discord Rich Presence
  6. Music Together
  7. Synced Lyrics

Additional Information

Снимок экрана от 2024-08-04 16-18-35

Снимок экрана от 2024-08-04 16-12-33

@seba0456
Copy link

seba0456 commented Aug 4, 2024

I have the same issue on Windows 11 too.

@Toxijuice
Copy link

I, too, am having this issue. I have not seen a single song that doesn't claim it hasn't found lyrics.
I can also confirm that while the lyrics do not populate, the fetch does return a valid response.
There is no error logged in the console when this occurs.

I am running the Portable version on Windows 10.

@Dan-tk
Copy link

Dan-tk commented Aug 7, 2024

I, too, am having this issue. I have not seen a single song that doesn't claim it hasn't found lyrics. I can also confirm that while the lyrics do not populate, the fetch does return a valid response. There is no error logged in the console when this occurs.

I am running the Portable version on Windows 10.

did you find any fix?

@ArjixWasTaken

This comment was marked as resolved.

@ArjixWasTaken
Copy link
Contributor

for the song displayed in the issue's description I see that lrclib has the artist name as Sam Tinnesz & Silverberg but youtube music has it as Silverberg & Sam Tinnesz

the algorithm compares the artist name, and since it is way too different, it doesn't find a result

@ArjixWasTaken
Copy link
Contributor

ArjixWasTaken commented Aug 7, 2024

for that, maybe we should split the artist name on &, to get multiple names

@Toxijuice
Copy link

Toxijuice commented Aug 8, 2024

did you find any fix?

Though I had trouble building an actual .exe to test, I built and previewed commit 32a572b, which appears to be working properly.

I assume commit ac51f79 is what fixed it, but can't guarantee that with 100% certainty.

please provide a link so I can reproduce it myself

The issue was not with one or even a few songs. I tested dozens of songs, none of which worked but when checked the data returned did contain the correct song and lyrics, so it would seem that the current version (66816ac) doesn't display those lyrics for one reason or another.

Either way, the issue seems to be resolved for me in more recent commits. Unless the problem has something to do with the build process, in which case I will know in the next official release, as my electron-builder is refusing to spit out an executable.

EDIT: I resolved my build issue, which seems to be related to Windows path length. So I can more reliably confirm that as of the latest commit (655741f), synced-lyrics appears to be fully functional.

@razeNFR
Copy link

razeNFR commented Aug 20, 2024

did you find any fix?

Though I had trouble building an actual .exe to test, I built and previewed commit 32a572b, which appears to be working properly.

I assume commit ac51f79 is what fixed it, but can't guarantee that with 100% certainty.

please provide a link so I can reproduce it myself

The issue was not with one or even a few songs. I tested dozens of songs, none of which worked but when checked the data returned did contain the correct song and lyrics, so it would seem that the current version (66816ac) doesn't display those lyrics for one reason or another.

Either way, the issue seems to be resolved for me in more recent commits. Unless the problem has something to do with the build process, in which case I will know in the next official release, as my electron-builder is refusing to spit out an executable.

EDIT: I resolved my build issue, which seems to be related to Windows path length. So I can more reliably confirm that as of the latest commit (655741f), synced-lyrics appears to be fully functional.

synced lyrics didnt work for me, how can i use your fix ?

@Toxijuice
Copy link

synced lyrics didnt work for me, how can i use your fix ?

Not my fix, those commits are from other people. I just manually built one of those commits.

If the issue you're experiencing is the same that I was, it will be fixed when the next official release comes around.

If you don't want to wait, you can try building it yourself following the instructions here. The build process is actually fairly straightforward, the only reason I had issues is because Windows has a hard time with longer paths. Cloning the repo to the root of a drive and building from there works just fine.

@razeNFR
Copy link

razeNFR commented Aug 21, 2024

synced lyrics didnt work for me, how can i use your fix ?

Not my fix, those commits are from other people. I just manually built one of those commits.

If the issue you're experiencing is the same that I was, it will be fixed when the next official release comes around.

If you don't want to wait, you can try building it yourself following the instructions here. The build process is actually fairly straightforward, the only reason I had issues is because Windows has a hard time with longer paths. Cloning the repo to the root of a drive and building from there works just fine.

Ok thank you, i will wait for official update.

@sadorowo
Copy link

I, too, am having this issue. I have not seen a single song that doesn't claim it hasn't found lyrics. I can also confirm that while the lyrics do not populate, the fetch does return a valid response. There is no error logged in the console when this occurs.
I am running the Portable version on Windows 10.

did you find any fix?

Try clearing cache (options -> advanced -> clear app cache when app starts).
After restarting the app, uncheck that.

@Toxijuice
Copy link

Try clearing cache (options -> advanced -> clear app cache when app starts). After restarting the app, uncheck that.

This does not have an effect for me in the current release version (3.5.1 / 66816ac). In my case all evidence points to it being a parsing issue that is fixed in recent commits.

I would still recommend anyone having this issue to try that, and report if it fixes the problem. Just in the event there are multiple bugs with synced lyrics.

@vipkingo1
Copy link

disabling my ad blocker seems to fix the issue for me or changing it to ad speedup instead of in player

@ArjixWasTaken
Copy link
Contributor

Let me clarify that this issue in particular is for songs have have multiple artists.

At least that is what the author of the issue is actually reporting.

Please make a different issue and give verbose details if you want your issue to get fixed.

@HKGx
Copy link

HKGx commented Sep 4, 2024

I've been having issues with lyrics - the requests certainly gets to LRCLIB and LRCLIB's response is alright.

Poking around with devtools I've noticed that this exact line:

let data = await response.json() as LRCLIBSearchResponse;

When called, is causing an issue with Electron itself.
I'm getting:

TypeError: Failed to execute 'json' on 'Response': Illegal invocation at Object.apply 

at

Response.prototype.json = new Proxy(Response.prototype.json, {
apply() {
return Reflect.apply(...arguments).then((o) => _prunerFn(o));
},
}); 0`,

I'm not really sure why that happens as I don't really have any sensible experience with Electron, so 🤷

And: yes, disabling the adblocker solves the issue

@ArjixWasTaken
Copy link
Contributor

@HKGx please change the adblocker method to "ad speedup" or "with blocklists"

The "in player" mode is the reason of the error

Although, I remember @JellyBrick fixing that particular issue months ago

@HKGx
Copy link

HKGx commented Sep 4, 2024

@ArjixWasTaken, I've disabled adbloker altogether as I'm paying for YT Premium. I just wanted to report an issue I've found. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants