-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: (Synced Lyrics) In some unknown conditions, lyrics doesn't display even if lyrics exists and found on LRCLIB. #2332
Comments
I have the same issue on Windows 11 too. |
I, too, am having this issue. I have not seen a single song that doesn't claim it hasn't found lyrics. I am running the Portable version on Windows 10. |
did you find any fix? |
This comment was marked as resolved.
This comment was marked as resolved.
for the song displayed in the issue's description I see that lrclib has the artist name as the algorithm compares the artist name, and since it is way too different, it doesn't find a result |
for that, maybe we should split the artist name on &, to get multiple names |
Though I had trouble building an actual .exe to test, I built and previewed commit 32a572b, which appears to be working properly. I assume commit ac51f79 is what fixed it, but can't guarantee that with 100% certainty.
The issue was not with one or even a few songs. I tested dozens of songs, none of which worked but when checked the data returned did contain the correct song and lyrics, so it would seem that the current version (66816ac) doesn't display those lyrics for one reason or another. Either way, the issue seems to be resolved for me in more recent commits. Unless the problem has something to do with the build process, in which case I will know in the next official release, as my electron-builder is refusing to spit out an executable. EDIT: I resolved my build issue, which seems to be related to Windows path length. So I can more reliably confirm that as of the latest commit (655741f), synced-lyrics appears to be fully functional. |
synced lyrics didnt work for me, how can i use your fix ? |
Not my fix, those commits are from other people. I just manually built one of those commits. If the issue you're experiencing is the same that I was, it will be fixed when the next official release comes around. If you don't want to wait, you can try building it yourself following the instructions here. The build process is actually fairly straightforward, the only reason I had issues is because Windows has a hard time with longer paths. Cloning the repo to the root of a drive and building from there works just fine. |
Ok thank you, i will wait for official update. |
Try clearing cache (options -> advanced -> clear app cache when app starts). |
This does not have an effect for me in the current release version (3.5.1 / 66816ac). In my case all evidence points to it being a parsing issue that is fixed in recent commits. I would still recommend anyone having this issue to try that, and report if it fixes the problem. Just in the event there are multiple bugs with synced lyrics. |
disabling my ad blocker seems to fix the issue for me or changing it to ad speedup instead of in player |
Let me clarify that this issue in particular is for songs have have multiple artists. At least that is what the author of the issue is actually reporting. Please make a different issue and give verbose details if you want your issue to get fixed. |
I've been having issues with lyrics - the requests certainly gets to LRCLIB and LRCLIB's response is alright. Poking around with devtools I've noticed that this exact line:
When called, is causing an issue with Electron itself.
at youtube-music/src/plugins/adblocker/index.ts Lines 129 to 133 in 4875955
I'm not really sure why that happens as I don't really have any sensible experience with Electron, so 🤷 And: yes, disabling the adblocker solves the issue |
@HKGx please change the adblocker method to "ad speedup" or "with blocklists" The "in player" mode is the reason of the error Although, I remember @JellyBrick fixing that particular issue months ago |
@ArjixWasTaken, I've disabled adbloker altogether as I'm paying for YT Premium. I just wanted to report an issue I've found. 😄 |
Preflight Checklist
YouTube Music (Application) Version
3.5.1
Checklists
What operating system are you using?
Other Linux
Operating System Version
Fedora 40, kernel: 6.9.12-200.fc40.x86_64
What CPU architecture are you using?
x64
Last Known Working YouTube Music (Application) version
No response
Reproduction steps
2.1 Lyrics not displayed
Expected Behavior
Lyrics displayed
Actual Behavior
"No lyrics found for this song"
See in additional information attached files
Enabled plugins
Additional Information
The text was updated successfully, but these errors were encountered: