Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: prevent request spamming Tuna when it's not launched #1596

Open
2 tasks done
Destroy666x opened this issue Jan 5, 2024 · 0 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@Destroy666x
Copy link
Contributor

Destroy666x commented Jan 5, 2024

Preflight Checklist

  • I use the latest version of YouTube Music (Application).
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

Tuna is spammed by requests even if it's not launched and thus also dev/debug log is spammed by error messages. Also ofc this is not too optimal since it happens on each elapsed time change.

Proposed Solution

The main idea would be to switch to "lazy" mode after X failed requests in a row (which could be configurable), what I mean by that is that the plugin would be basically stopped after that and only do much less frequent light requests (HEAD?) to check if Tuna is back online. Once a positive reply is recceived, it could switch back to regular mode.

Alternatives Considered

Another idea would be to activate the feature by Tuna sending a signal to YTM, e.g. a request, whenever it's ready to receive and awaiting data combined with X retries/timeout on YTMs side and then completely disabling the feature until receiving the signal. But this requires changes from Tuna and from what I know that project is inactive.

Additional Information

No response

@JellyBrick JellyBrick added the enhancement New feature or request label Jan 6, 2024
@JellyBrick JellyBrick reopened this Jan 16, 2024
@JellyBrick JellyBrick reopened this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants