Fix hypernoblium formation gas reaction rate sanity clamping not accounting for the reduction factor. Also other sanity fixes. #76177
Conversation
Fixes hypernoblium formation reaction rate mole count sanity min check. Does this by calculating the bz reduction factor before reaction rate (fuck, I am on mobile and I can not see what I am typing, also I kinda forgot what I said AAAAAAAAAAAA) calculating the reaction rate. It then applies the product of the tritium consumption rate and reduction factor thinf uhh it sucks typing without seeing what I'm writing AAAAAAAA thrhfhfjjgjjhdhshgfsjsbdhhdbzjabdjahsjcnakdbd
tgstation-server
added
the
Fix
|
You currently have a negative Fix/Feature pull request delta of -4. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
Fixes N2O formation sanity checks by making them correctly scale with their consumption rate. This was probably my fault like a year ago when I changed shit.
Pickle-Coding
changed the title
Fixes bz formation reaction rate sanity clamping to account for nitrous oxide decomposed factor.
|
When you say 'Sanity Clamping', what does that mean? [Just my first time hearing this phrase] |
|
Clamp reaction rate to not consume more moles than there is, so no negative moles or creating gas from nothing bullshit. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
github-actions
bot
added
the
Stale
…nity clamping not accounting for the reduction factor. Also other sanity fixes. (#6562) Original PR: tgstation/tgstation#76177 ----- ## About The Pull Request Fix hypernoblium formation not accounting for the reduction factor when sanity clamping the reaction rate. Fix N2O formation not using updated consumption rates for sanity checks. Fix BZ formation not accounting for nitrous oxide decomposition factor for reaction rate sanity clamping. ## Why It's Good For The Game So the reactions are more natural. ## Changelog :cl: fix: Fix hypernoblium formation gas reaction rate sanity clamping not accounting for the reduction factor. fix: Fix N2O formation gas reaction rate clamping clamping for incorrect consumption rates. fix: Fix BZ formation reaction rate sanity clamping not accounting for N2O decomposition factor. /:cl: --------- Co-authored-by: Pickle-Coding <[email protected]>
About The Pull Request
Fix hypernoblium formation not accounting for the reduction factor when sanity clamping the reaction rate.
Fix N2O formation not using updated consumption rates for sanity checks.
Fix BZ formation not accounting for nitrous oxide decomposition factor for reaction rate sanity clamping.
Why It's Good For The Game
So the reactions are more natural.
Changelog
🆑
fix: Fix hypernoblium formation gas reaction rate sanity clamping not accounting for the reduction factor.
fix: Fix N2O formation gas reaction rate clamping clamping for incorrect consumption rates.
fix: Fix BZ formation reaction rate sanity clamping not accounting for N2O decomposition factor.
/:cl: