fix devices sprites on layer 1 and 5

[Ghilker]

About The Pull Request

This atomized PR fixes the sprites for layer 1 and 5 of the following devices:
-scrubber
-unary vent
-passive vent
-portable connector
-filter filters don't work well on layer 1 and 5, so they get the axe
-mixer mixers don't work well on layer 1 and 5, so they get the axe
The how:
instead of just moving the node, we'll move the entire thing because sprites bad and can't fit

• PR ready

Why It's Good For The Game

better sprites

Changelog

🆑
fix: fix sprite jank on layer 1 and 5
/:cl:

[Ghilker]

f wait i need to fix the filters and mixers

[Ghilker]

filters and mixers don't work well on layer 1 and 5

[Ghilker]

added

[Ghilker]

older one without the offsets

[trerri]

If anyone ever considers merging this please realize that it implies that EVERY roundstart vent and scrubber will be misaligned to the tiles it's on, since distro and waste are not on layer 3.

Also, killing the layers of compatibility for trinary components kinda blows. Layer 1 and 5 mixers/filters are very useful.

The first image with the offsets on the components is cool though (because it was my idea 😎)

[Ghilker]

If anyone ever considers merging this please realize that it implies that EVERY roundstart vent and scrubber will be misaligned to the tiles it's on, since distro and waste are not on layer 3.

Also, killing the layers of compatibility for trinary components kinda blows. Layer 1 and 5 mixers/filters are very useful.

The first image with the offsets on the components is cool though (because it was my idea 😎)

i know the problem of misaligned vents and scrubbers, but that's the price for changing all distro and waste to 1 and 3 (now 2 and 4)

the filters and mixers for 1 and 5 is still a maybe, if you can post picture of them at layer 1 and 5 people and maintainers could think about them and if they are no big deal i'll keep them

[trerri]

the filters and mixers for 1 and 5 is still a maybe, if you can post picture of them at layer 1 and 5 people and maintainers could think about them and if they are no big deal i'll keep them

shes a beaut

[LemonInTheDark]

I'll take a look at the distro thing, it should be alright, but we'll see

If filters look like that they need the bullet, it's just too far.

[Ghilker]

Layer 2 and 4 are just slightly misaligned and they don't go over the tile

I agree that filter and mixers are useful but if there isn't a way to make them work ill axe them

[trerri]

Going off this image:

You could pixel shift it to the north east a little bit, and when it's in layer 2 or 4 instead of 1 or 5 you could pixel shift it still, but only half of the amount of the edge layers, for consistency's sake. Here's a shitty mockup of how that would look:

And for layers 2 and 4:

trerri singlehandedly saves tgstation atmospherics once again, what a hero

EDIT: the layer5 filter is pixel shifted by 2 on x and y, the layer4 one by 1.

[Ghilker]

filters and mixers now work on layer 1 and 5 without jank

[Ghilker]

scrubbers and vents now align back in the center of the tile if covered by floor

[trerri]

i love ghilker

[LemonInTheDark]

We love ghilker