Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds bloodthirster Rav strain #16664

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Oct 12, 2024

About The Pull Request

Numbers are REALLY in doubt

Adds the bloodthirster rav strain, intended to lean more into the aggressive risk taking that rav does

Bloodthirster has the bloodthirst mechanic, which more or less means it only gets plasma through slashes, plasma decays when not attacking enemies, and not attacking for a while deals damage to you until you're down to 100hp
But if you deal damage you get longer ranges and stronger charge and ravage, and rage speed bonus is multiplied

Primo:
Deathmark
Mark yourself for death, deal 400 damage in 40 seconds or die but you get speed buffs and full rage for the duration

Why It's Good For The Game

variety or something

Changelog

🆑
add: Added the bloodthirster ravager strain, which takes damage when not dealing damage, but gets buffs from dealing a lot of damage
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Feature New interesting mechanics with new interesting bugs labels Oct 12, 2024
@Naaanii
Copy link
Contributor

Naaanii commented Oct 12, 2024

Holy based...

@Xander3359
Copy link
Contributor

Captain, another ravager has hit the ground side.

@demir-pl
Copy link

now this is a GOOD PR (speedmerge NOW)
design good - idea amazing - more combat? FANTASTIC love that

thinking about stats i would love to suggest:

-max health would be nice but maybe that's too much? - 500/550?
maybe make bloodthirst level increase health + sunder multi? instead of just plasma (more rewards for damage)
-raising bomb armor to 20 25 so you don't get 1 shot by sadars or can take few nades, maybe make make bomb armor/armor grow with bloodthirst
-important would be raising endure health (i would say up to -150/200 health instead of -100)
-raising the bloodthirst decay health to a reasonable 150? so you aren't a sitting duck for a sniper

also if he is meant to be more combat focused (he will die without dealing damage its combat to the max) i ask (demand) for ability cooldown change - i would say 50% compared to base rav (30 seconds instead of 60 on endure/rage - 10 seconds on charge - ravage to 5 seconds?)

last note would be testing how possible is 400 damage in 40 seconds (probably moderate difficulty but who knows...)

but that's just my dumb thoughts without knowledge/testing

HOLY SHIT THIS SOUNDS SO GOOD AUGH!!!! TIME TO GET 1 TAPPED OFF SCREEN BY REQ SLOP WITH NO COUNTER!!! WOOO HOOO!!!!!!!!!! (jk actually loving it)

@DrAmazing343
Copy link

I like the idea but ultimately I think aside from a cooldown reduction we gotta be reaaaal careful with the numbers. Really good normal ravs are super fucking hard to kill, but also solo murder machines. This would turn those ravs into genuinely unkillable colombian murder machines on crack.

@iforgotmeword
Copy link

iforgotmeword commented Oct 13, 2024

i say bump that min HP to like 180 or something like that
100HP for a rav (big target) is not much
also any change in it's sprites?

also also do something for when high jacking being stuck with min HP because you killed all of the marines shouldn't be a thing

also also also death mark seems busted? 40 secs is a very long time

@Arturlang
Copy link
Contributor

Arturlang commented Oct 13, 2024

Current normal rav isn't really in a good spot right now, doesn't feel like it competes with the other buffed xenos all that well, would be fun to see how this one works out.
Rav in general has really needed extra endure health as most things will just pop you before you can do anything, relegating endure/rage to a escape tool.

xeno.emote("roar")

/// on attack for deathmark, tracks the amount of dmg dealt
/datum/action/ability/xeno_action/deathmark/proc/on_attack(datum/source, mob/living/attacked, damage)
Copy link
Contributor

@Arturlang Arturlang Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, assuming that the rav only really slashes to try to fulfill deathmark's 400 damage threshold, as COMSIG_XENOMORPH_ATTACK_LIVING outputs xeno's slash damage times whatever damage modifier it has, but I'll just assume it's 25 as it usually is, 400/25, means you need to do 16 slashes to not die, which means you'd probably have to kill two marines just to not die, unless they're incredibly tanky because of tyr 2.
Though i'm not really accounting for charge as that can multihit easily

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh 16 slashes isn't that much but might get fucky if you're focused - but full rage is really good since you well.. have full rage - FULL HEAL + temp sunder(like rage) would also be huge, but it might be bit far (but it is primo ability after all)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Means you have 2.5 seconds to do each slash or you'll simply run out of time.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think that 40 seconds is doable since you can slash prerty fast but only tm can show us - also timer in some way would be good - maybe same as time until endure/rage runs out? Screen effects too maybe? Or maybe a glowy aura changing on time - something so you aren't surprised how fast 40 seconds passed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use the screen timer thingy or do a similar thing on the mob itself

@Pariah919
Copy link
Contributor

Pariah919 commented Oct 17, 2024

wait the ravage and endure are 0 cost? what's the point of plasma?
This generally seems like a straight upgrade.

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024
Comment on lines +16 to +27
/mob/living/carbon/xenomorph/get_crit_threshold()
. = ..()
if(!endure)
return
var/datum/action/ability/xeno_action/endure/endure_ability = actions_by_path[/datum/action/ability/xeno_action/endure]
return endure_ability.endure_threshold

/mob/living/carbon/xenomorph/get_death_threshold()
return xeno_caste.crit_health
if(!endure)
return xeno_caste.crit_health
var/datum/action/ability/xeno_action/endure/endure_ability = actions_by_path[/datum/action/ability/xeno_action/endure]
return endure_ability.endure_threshold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe out of scope, but all these funny xeno mob action checks should presumably be handled via signals

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shrug prolly

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
@Lumipharon
Copy link
Contributor

Also xenos still can't strainswap themselves, and normal ravs come up as bloodthirsters in the hive list

@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
@AndroidMK2
Copy link

How long until the damage taking from not slashing kicks in?

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 12, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 19, 2024
@github-actions github-actions bot closed this Nov 22, 2024
@TiviPlus TiviPlus reopened this Nov 27, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 27, 2024
@TiviPlus TiviPlus added Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. and removed Stale Pull request is awaiting delayed author response and may be closed. labels Nov 27, 2024
comfyorange added a commit that referenced this pull request Nov 27, 2024
@blackdav123
Copy link
Contributor

health reduction mechanic doesnt work right because it deals damage to you which gives rage and resets the timer for reducing health.

@demir-pl
Copy link

you cant caste swap since you keep taking damage/not enough plasma

@Technical-l
Copy link
Contributor

played a bit of bloodthirster and i just wanna detail some of the things i experienced here

endure is completely broken right now, if you enter crit while under the effects of endure, you instantly die

getting to max rage and keeping it there doesn't seem to be that difficult at all. So long as you fight semi-regularly, rage becomes a non-factor in how you play.

The death mark primo is ABSURDLY fast. Faster than old bull primo fast. I don't think i've ever seen a xeno move as fast as a raging deathmarked bloodthirster before. It actually makes it really hard to hit marines, but i've only played with it once before i got the hang of the abilities.

as it stands right now, bloodthirster seems to be a straight upgrade from rav. It'd be wildly OP if endure wasn't broken right now, and i don't really think the bloodthirsters rage mechanics are in a good spot right now. It doesn't feel much like a berserker right now, more just a rav who traded endure for extra range.

. = ..()
if(!endure)
return
var/datum/action/ability/xeno_action/endure/endure_ability = actions_by_path[/datum/action/ability/xeno_action/endure]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bloodthirster uses a different path (/endure/nocost) so i don't think this works correctly.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch this was probably it

@blackdav123
Copy link
Contributor

the ranged ravage goes through walls which is goofy

comfyorange added a commit that referenced this pull request Dec 6, 2024
@MLGTASTICa
Copy link
Contributor

I'd change the rage mechanic to be acquired only through succesfully employing ravage/charge through people and for it to be used up on slashes to increase damage instead. As of now you can keep it maxed out all the time with just regular combat and it doesnt do a whole lot.

comfyorange added a commit that referenced this pull request Dec 8, 2024
comfyorange added a commit that referenced this pull request Dec 10, 2024
comfyorange added a commit that referenced this pull request Dec 12, 2024
comfyorange added a commit that referenced this pull request Dec 12, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Dec 14, 2024
comfyorange added a commit that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Sprites Changes to .dmi file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.