Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xeno maw and jaw structures #16663

Merged
merged 10 commits into from
Nov 23, 2024
Merged

Xeno maw and jaw structures #16663

merged 10 commits into from
Nov 23, 2024

Conversation

TiviPlus
Copy link
Member

@TiviPlus TiviPlus commented Oct 12, 2024

About The Pull Request

finished it up, WIP needs testing
and ideally minimap icons for both as well

Buy maw with points click it as hive ruler to open radial menu after selecting bombardment type click on minimap to fire

Acid Jaws: costs 600 tac points, cannot be in caves
Fire:
5 minute CD, 4 turf radius of basically a pyrogen fireball, 6 sec cd

Hugger: 3 minute cd, 6 sec impact, drops 30 random huggers in a 8 tile radius

Smoke: Shoots neuro smoke 6 second impact, 1 sec lasting, radius 4 (can easily shoot more if I get radial sprites for it), cooldown 4 min

Acid Maw: 1600 strategic points, can be in caves, fires 10 tile radius acid gas bombardments that last 2 sec every 10 minutes, shots are announced, impact time 6 seconds

Why It's Good For The Game

Xeno indirect fire be like

Changelog

🆑
add: Added the new acid maw and acid jaws xeno structures
/:cl:

@tgstation-server tgstation-server added Sprites Changes to .dmi file. Sound Sound change. Feature New interesting mechanics with new interesting bugs labels Oct 12, 2024
@DorfGuy1
Copy link

Pls no more ranged xeno stuff. Marine indirect fire sucks, you cant just give xenos better howitzers than marines

@blackdav123
Copy link
Contributor

two and a half primos or 2 seconds of gas :clueless:

@Mannybrado
Copy link
Contributor

two and a half primos or 2 seconds of gas :clueless:

@iforgotmeword
Copy link

iforgotmeword commented Oct 13, 2024

speed merge this is a other step to Xeno VS marine campaign
also GIVE ME HARDER BATTLES

@novaepee
Copy link
Contributor

it would be nice if boilers get to shoot from xeno mau and jaw; fitting of the caste

@Isy232
Copy link
Contributor

Isy232 commented Oct 15, 2024

I strongly approve of this as something to allow xenos to resolve 2 hour long FOB siege's, which still happen sometimes.

Additionally, I wish for marine engineering to recieve buffs to be more impactful which of course increases the probability of 2 hour sieges. Xenos having strategic weapon options to counter improved marine defenses and end sieges sounds great.

Copy link
Contributor

@Lumipharon Lumipharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat


/datum/maw_ammo/hugger/impact_visuals(turf/target)
var/list/turf/turfs = RANGE_TURFS(drop_range, target)
assignturfs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have ever seen a block label used, neat

@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 16, 2024
comfyorange added a commit that referenced this pull request Oct 16, 2024
@tgstation-server tgstation-server removed the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 16, 2024
comfyorange added a commit that referenced this pull request Oct 16, 2024
@Mannybrado
Copy link
Contributor

A QoL request: Building a maw/jaw should place a tunnel next to it in the same way that the silo does.

comfyorange added a commit that referenced this pull request Oct 17, 2024
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 17, 2024
@jroinc
Copy link
Contributor

jroinc commented Oct 17, 2024

some of these seem really really weak for the costs involved; most of them last for what, one tick?

the hugger one seems OP in comparison

comfyorange added a commit that referenced this pull request Oct 17, 2024
@DorfGuy1
Copy link

I strongly approve of this as something to allow xenos to resolve 2 hour long FOB siege's, which still happen sometimes.

Additionally, I wish for marine engineering to recieve buffs to be more impactful which of course increases the probability of 2 hour sieges. Xenos having strategic weapon options to counter improved marine defenses and end sieges sounds great.

Xenos already have something for fob sieges. Also those don't happen anymore because most defenses can be removed with great ease. They don't need artilery. They're just going to add this and then leave the rest alone. Xenos do not need more things. They never got the nerfs that were supposed to come with the Aim mode removal.

comfyorange added a commit that referenced this pull request Oct 17, 2024
comfyorange added a commit that referenced this pull request Oct 18, 2024
comfyorange added a commit that referenced this pull request Oct 19, 2024
@Runian
Copy link
Contributor

Runian commented Oct 19, 2024

Acid Jaws can be placed (in Pillar of Springs) and used shipside. Intentional?

comfyorange added a commit that referenced this pull request Oct 21, 2024
comfyorange added a commit that referenced this pull request Oct 24, 2024
@github-actions github-actions bot added the Merge Conflict Pull request is in a conflicted state with base branch. label Oct 26, 2024
@tgstation-server tgstation-server removed Merge Conflict Pull request is in a conflicted state with base branch. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. labels Oct 26, 2024
comfyorange added a commit that referenced this pull request Oct 26, 2024
comfyorange added a commit that referenced this pull request Oct 26, 2024
comfyorange added a commit that referenced this pull request Oct 28, 2024
comfyorange added a commit that referenced this pull request Oct 28, 2024
comfyorange added a commit that referenced this pull request Oct 29, 2024
@LunarSearching
Copy link

no reason for why it's good for the game? at least put something that's a bad argument instead of adding nothing to it, also, xenos pretty much already got indirect fire, in a way, via the boiler, and FOB sieges that last long almost never happen, it's going to be mainly used for disk holds, pretty sure this is going to be added and unused unless if xenos lack a boiler or for niche stuff, that's at least the point of view of me, a player, i might be extremely wrong in thinking this was though

@blackdav123
Copy link
Contributor

doesnt have minimap icon or show on the hive structures list in hive status

@PibeCantina
Copy link
Contributor

So

Hugger mortar is by far the best option, neuro cloud could be good but it's nothing that other xenos can't do better already. Huggers are simply way better at disrupting a formation than any other option.
The 1600 (i think it was this) is the most dogshit purchase you can make with your points, it wouldn't be worth it even if it were tac points, not strategic
For 1600 points you can get 2 silos, or a single transparent acid blob that can be deleted by handheld grenades EVERY 10 MINUTES
Honestly i like it because it adds to the combo potential of coordinated xenos, but the only thing that's ever worth it is huggers and nothing else, the rest is worse than that or plain awful.
Good PR though i like it

comfyorange added a commit that referenced this pull request Nov 2, 2024
comfyorange added a commit that referenced this pull request Nov 7, 2024
comfyorange added a commit that referenced this pull request Nov 7, 2024
@Lumipharon Lumipharon added the Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes. label Nov 15, 2024
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 3 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale Pull request is awaiting delayed author response and may be closed. label Nov 23, 2024
@Kuro020 Kuro020 merged commit 7b27595 into tgstation:master Nov 23, 2024
40 checks passed
github-actions bot added a commit that referenced this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New interesting mechanics with new interesting bugs Sound Sound change. Sprites Changes to .dmi file. Stale Pull request is awaiting delayed author response and may be closed. Test Merge Candidate This PR has been reviewed and is ready for testing, unless something changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.