Fix type hint support for functools cached_property wrapped funcs #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functools added a `cached_property` wrapper in Python 3.8. Support type hinting for properties wrapped in both Django's `cached_property` and functool's `cached_property`.
Codecov Report
@@ Coverage Diff @@
## master #501 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 57 57
Lines 5710 5729 +19
=======================================
+ Hits 5629 5648 +19
Misses 81 81
Continue to review full report at Codecov.
|
jalaziz
force-pushed
the
functools-cached_property
branch
from
731afde to
5743e4a
Compare
tfranzel
added a commit
that referenced
this pull request
Sep 9, 2021
|
very nice @jalaziz! thanks for the PR. i added a testcase to actually test the output of the endpoint to make sure the expectations on the outcome are also matched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functools added a
cached_propertywrapper in Python 3.8. Support typehinting for properties wrapped in both Django's
cached_propertyandfunctool's
cached_property.This came up while fixing system check warnings. I couldn't figure out why
the "property" was being reported as "magic" until I checked the type
hinting detection source code.