Fixed bug with cached_property non-Model objects not being traversed
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, paths like source="sub_object.part" were not being traversed to find type annotations for `part` if `sub_object` was a non-Model class defined using `cached_property` instead of `property`. Tests are added for both the `property` and `cached_property` cases, and some further recursive possibilities. e.g. going back to a Model class.
Codecov Report
@@ Coverage Diff @@
## master #329 +/- ##
==========================================
- Coverage 98.22% 98.15% -0.08%
==========================================
Files 53 54 +1
Lines 4729 4925 +196
==========================================
+ Hits 4645 4834 +189
- Misses 84 91 +7
Continue to review full report at Codecov.
|
tfranzel
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
thanks @spookylukey, another awesome change! i just had to sit back a second and appreciate that this actually supports recursion for arbitrary hinted objects.
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, paths like source="sub_object.part" were not being traversed to find type annotations for
partifsub_objectwas a non-Model class defined usingcached_propertyinstead ofproperty.Tests are added for both the
propertyandcached_propertycases, and some further recursive possibilities. e.g. going back to a Model class.