Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentence-splitter のアップデート #131

Closed
5 tasks done
azu opened this issue Nov 24, 2023 · 3 comments · Fixed by #139
Closed
5 tasks done

sentence-splitter のアップデート #131

azu opened this issue Nov 24, 2023 · 3 comments · Fixed by #139
Labels
Type: Breaking Change Includes breaking changes

Comments

@azu
Copy link
Member

azu commented Nov 24, 2023

GitHubに追加された次の構文で一部ルールに影響が出てる

Note

some content

この構文が https://github.com/textlint-rule/sentence-splitter v3だと正しく解析できない。
具体的に問題が起きるケースは、textlint-rule/textlint-rule-no-unmatched-pairだけな気はするが、壊れてる可能性があるので、まとめてアップデートしたい。

sentence-splitterへの依存

https://npmgraph.js.org/?q=textlint-rule-preset-ja-technical-writing#select=exact%3Asentence-splitter%403.2.3

このv3に依存してるルールをv4v5へまとめてあげる必要がある。
sentence-splitter v5でNode.js 18+にしたので、v5まであげる。

TODO

それぞれsentence-splitterをv3からv4v5へアップデートする

related

@azu azu added good first issue Good for newcomers Type: Dependencies Dependency issues or Changes to dependency files labels Nov 24, 2023
@azu azu added Type: Breaking Change Includes breaking changes and removed good first issue Good for newcomers Type: Dependencies Dependency issues or Changes to dependency files labels Nov 26, 2023
@azu
Copy link
Member Author

azu commented Nov 26, 2023

これ取り込んでリリースしてしまうかな。
半年の一回だと次は1月になってしまうので若干遠い

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Includes breaking changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant