Skip to content
This repository has been archived by the owner on Apr 13, 2021. It is now read-only.

Provide sort, seek, limit, etc #661

Merged
merged 1 commit into from
Jan 18, 2021
Merged

Provide sort, seek, limit, etc #661

merged 1 commit into from
Jan 18, 2021

Conversation

carsonfarmer
Copy link
Member

@carsonfarmer carsonfarmer commented Jan 8, 2021

Description

Brings threads-client query functionality back in sync with go-threads. Includes seek, limit, skip, and a few other features at the top level APIs. Also updates the (minimal) test to reflect some of these new APIs.

Fixes #140

Is related to textileio/go-threads#478 (which really should be merged before we expose this more broadly at the JS layer.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing tests should continue to pass, and one test has been modified to include the updated changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

This PR template comes from https://github.com/embeddedartistry/templates

@carsonfarmer carsonfarmer added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 8, 2021
@carsonfarmer carsonfarmer self-assigned this Jan 8, 2021

/**
* or concatenates a new condition that is sufficient for an instance to
* satisfy, independant of the current Query. Has left-associativity as:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[misspell] reported by reviewdog 🐶
"independant" is a misspelling of "independent"

Copy link
Member

@andrewxhill andrewxhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@carsonfarmer carsonfarmer merged commit 72b2c38 into master Jan 18, 2021
@carsonfarmer carsonfarmer deleted the carson/sort-seek branch January 18, 2021 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Offset and Limit in Query
2 participants