Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid log information from getOwnLog if peer doesn't 'own' the log #373

Closed
carsonfarmer opened this issue Jun 10, 2020 · 0 comments · Fixed by #374
Closed

Invalid log information from getOwnLog if peer doesn't 'own' the log #373

carsonfarmer opened this issue Jun 10, 2020 · 0 comments · Fixed by #374
Assignees
Labels
bug Something isn't working
Milestone

Comments

@carsonfarmer
Copy link
Member

Creating a Thread on a (remote) peer/daemon doesn't require the client to provide the private key for it to be created. This is great, as it supports using the remote daemon/peer as a 'proxy' peer for doing 'trustless' log updates for a given remote client peer. Unfortunately, some of our existing internal logic assumes 'ownership' of a log is represented by having the private key. This is a reasonable assumption in many cases, but doesn't support the use case listed above. To remedy this, some more general concept of 'ownership' should be considered. In practice, this might look like 'flagging' logs created by the daemon/peer directly with a 'Direct' bool flag, indicating that this log is managed directly by this peer. To keep backward compatibility, we could still check for 'ownership' in the strict sense via the existence of a private key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant