Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Add new tags for single entity #67

Merged
merged 1 commit into from
Feb 19, 2017

Conversation

Schyzophrenic
Copy link
Contributor

@Schyzophrenic Schyzophrenic commented Feb 12, 2017

Bugfix for #51
The support of new tags was limited to multiple entries. This should do the trick for the single entity as well.
Please note I also removed a query in the transform function as it seemed useless but I didn't understand the comment.
I am happy to modify this if you can provide more insight about the usage.

Moving forward, it may be of interest to have a parent class as a lot of code is duplicated between EntityToPropertyTransformer and EntitiesToPropertyTransformer.

Thanks!

@tetranz
Copy link
Owner

tetranz commented Feb 12, 2017

Thanks, I'll look at this in the next few days. I remember that query when it was added by another PR. I'll take a look and see if it serves a purpose.

@tetranz
Copy link
Owner

tetranz commented Mar 22, 2017

Sorry @mitch10593, I got confused seeing your same comment on two different PRs. I will add your custom object manager code back, hopefully in the next day or so. My mistake for not checking the PRs carefully enough.

@tetranz
Copy link
Owner

tetranz commented Mar 24, 2017

@mitch10593 I have restored your custom entity code on master with #72 I'll release a new version in a few days. My apologies for letting this happen. Obviously some tests would have avoided this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants