Fix Add new tags for single entity #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll look at this in the next few days. I remember that query when it was added by another PR. I'll take a look and see if it serves a purpose. |
|
Sorry @mitch10593, I got confused seeing your same comment on two different PRs. I will add your custom object manager code back, hopefully in the next day or so. My mistake for not checking the PRs carefully enough. |
|
@mitch10593 I have restored your custom entity code on master with #72 I'll release a new version in a few days. My apologies for letting this happen. Obviously some tests would have avoided this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for #51
The support of new tags was limited to multiple entries. This should do the trick for the single entity as well.
Please note I also removed a query in the transform function as it seemed useless but I didn't understand the comment.
I am happy to modify this if you can provide more insight about the usage.
Moving forward, it may be of interest to have a parent class as a lot of code is duplicated between EntityToPropertyTransformer and EntitiesToPropertyTransformer.
Thanks!